<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 3, 2014 at 7:47 PM, Alexey Bataev <span dir="ltr"><<a href="mailto:a.bataev@hotmail.com" target="_blank">a.bataev@hotmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Richard,<br>
Thanks for review.<br>
But I made this changes just to be fully compatible with the previous one made by Aaron Ballman (see changes in revision 203937).<br></blockquote><div><br></div><div>Yes, those are bad names too. Feel free to fix them all =)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Best regards,<br>
Alexey Bataev<br>
=============<br>
Software Engineer<br>
Intel Compiler Team<br>
Intel Corp.<br>
<br>
3 Апрель 2014 г. 22:04:27, Richard Smith писал:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
On Wed, Apr 2, 2014 at 7:55 PM, Alexey Bataev <<a href="mailto:a.bataev@hotmail.com" target="_blank">a.bataev@hotmail.com</a><br></div><div><div class="h5">
<mailto:<a href="mailto:a.bataev@hotmail.com" target="_blank">a.bataev@hotmail.com</a>>> wrote:<br>
<br>
Author: abataev<br>
Date: Wed Apr 2 21:55:46 2014<br>
New Revision: 205506<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=205506&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=205506&view=rev</a><br>
Log:<br>
[OPENMP] Small update for C++11<br>
<br>
Modified:<br>
cfe/trunk/lib/Sema/<u></u>TreeTransform.h<br>
cfe/trunk/lib/Serialization/<u></u>ASTWriterStmt.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/<u></u>TreeTransform.h<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/TreeTransform.h?rev=205506&r1=205505&r2=205506&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/Sema/<u></u>TreeTransform.h?rev=205506&r1=<u></u>205505&r2=205506&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Sema/<u></u>TreeTransform.h (original)<br>
+++ cfe/trunk/lib/Sema/<u></u>TreeTransform.h Wed Apr 2 21:55:46 2014<br>
@@ -6439,10 +6439,8 @@ OMPClause *<br>
TreeTransform<Derived>::<u></u>TransformOMPCopyinClause(<u></u>OMPCopyinClause<br>
*C) {<br>
llvm::SmallVector<Expr *, 16> Vars;<br>
Vars.reserve(C->varlist_size()<u></u>);<br>
- for (OMPCopyinClause::varlist_<u></u>iterator I = C->varlist_begin(),<br>
- E = C->varlist_end();<br>
- I != E; ++I) {<br>
- ExprResult EVar = getDerived().TransformExpr(<u></u>cast<Expr>(*I));<br>
+ for (auto *I : C->varlists()) {<br>
<br>
<br>
This is not an iterator, so should not be named I.<br>
<br>
+ ExprResult EVar = getDerived().TransformExpr(<u></u>cast<Expr>(I));<br>
if (EVar.isInvalid())<br>
return 0;<br>
Vars.push_back(EVar.take());<br>
<br>
Modified: cfe/trunk/lib/Serialization/<u></u>ASTWriterStmt.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTWriterStmt.cpp?rev=205506&r1=205505&r2=205506&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/<u></u>Serialization/ASTWriterStmt.<u></u>cpp?rev=205506&r1=205505&r2=<u></u>205506&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Serialization/<u></u>ASTWriterStmt.cpp (original)<br>
+++ cfe/trunk/lib/Serialization/<u></u>ASTWriterStmt.cpp Wed Apr 2<br>
21:55:46 2014<br>
@@ -1719,10 +1719,8 @@ void OMPClauseWriter::<u></u>VisitOMPSharedClau<br>
void OMPClauseWriter::<u></u>VisitOMPCopyinClause(<u></u>OMPCopyinClause *C) {<br>
Record.push_back(C->varlist_<u></u>size());<br>
Writer->Writer.<u></u>AddSourceLocation(C-><u></u>getLParenLoc(), Record);<br>
- for (OMPCopyinClause::varlist_<u></u>iterator I = C->varlist_begin(),<br>
- E = C->varlist_end();<br>
- I != E; ++I)<br>
- Writer->Writer.AddStmt(*I);<br>
+ for (auto *I : C->varlists())<br>
<br>
<br>
Likewise.<br>
<br>
+ Writer->Writer.AddStmt(I);<br>
}<br>
<br>
//===-------------------------<u></u>------------------------------<u></u>---------------===//<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br></div></div>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br>
</blockquote>
</blockquote></div><br></div></div>