<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Hi Tom,</div><div class="gmail_extra"><div class="gmail_quote"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;display:inline">
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">In principle, I don't really have a problem with this kind of change going<br>

into the stable branch since it only modifies two backends<br>
and not common code, but I would like to know how these changes affect<br>
the <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;display:inline"></div>non-neon parts of the AArch64 and ARM backends?<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
For the changes of <div class="gmail_default" style="display:inline"></div><span style="font-family:arial">non-neon parts of the AArch64 and ARM backends, I listed them as below previously.</span></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
<span style="font-family:arial"><br></span></div>* Change 64-bit integer type int64_t mapping from "long long" to "long" and it potentially affects binary compatibility.<br>* va_copy run-time behavior failure for AArch64.<br>
* Fix a silent codegen fault for atomic operations (e.g. __sync_... Intrinsics).<br>* Fix an assertion failure in A15 SDOptimizer about DPair reg class by treating DPair as QPR.<br>* Fix ARM back-end ld/st for v1i64 vector list failure around writeback mode.<div>
 <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Also, in order to be accepted, these changes will need to be approved by<br>
the code owners for both ARM and AARCH64 and we will need to verify that<br>
these patches don't change the ABI.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">The owners of those patches are </div><br></div><div>
<div class="gmail_default"><span style="font-family:arial,helvetica,sans-serif"></span><font face="arial, helvetica, sans-serif"> * adibiagio :</font><span style="font-family:arial,helvetica,sans-serif">r198084 </span><br>
</div></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"> * apazos <span style="white-space:pre">: </span>r197928 </font><span style="font-family:arial,helvetica,sans-serif">r197929</span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre">      </span><span style="font-family:arial,helvetica,sans-serif">r198437 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198791 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199242 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201112 </span></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif"> * chandlerc<span style="white-space:pre">: </span>r199631</font></div><div class="gmail_default"><span style="font-family:arial,helvetica,sans-serif"> * haoliu:<span style="white-space:pre"> </span></span><span style="font-family:arial,helvetica,sans-serif">r196748 </span><span style="font-family:arial,helvetica,sans-serif">r196749 </span><span style="font-family:arial,helvetica,sans-serif">r197135 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197361 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197897 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197969 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198001 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198188 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198192 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198193 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198682 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198684 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198730 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199461 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199463 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199861 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201061 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201287 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">201298 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre">  </span><span style="font-family:arial,helvetica,sans-serif">r201381 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r204304 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196750 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197898 </span></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif"> * jiangning <span style="white-space:pre">: </span>r197993 </font><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre">    </span><span style="font-family:arial,helvetica,sans-serif">r198194 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199296 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199369 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200113 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200119 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201385 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201541 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197994 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198195 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198741 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200114 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201384 </span></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif"> * kbeyls:<span style="white-space:pre"> </span>r198937 </font><span style="font-family:arial,helvetica,sans-serif">r198941 </span></div><div class="gmail_default">
<font face="arial, helvetica, sans-serif"> * kevinqin<span style="white-space:pre">: </span>r196887</font><span style="font-family:arial,helvetica,sans-serif">r196889</span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196998 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197113 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197551 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197966 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197967 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198190 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198675 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r198743 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199069 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199070 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199462 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199485 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199621 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199628 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199791 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">199858 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre">  </span><span style="font-family:arial,helvetica,sans-serif">r199978 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200109 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200110 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200111 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200179 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200180 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200365 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201395 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r201841 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r202775 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r204424 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196888 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197112 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r199866 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r202004 </span></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif"> * mcrosier:<span style="white-space:pre"> </span>r196831</font><span style="font-family:arial,helvetica,sans-serif">r196832 </span><span style="font-family:arial,helvetica,sans-serif">r196833 </span><span style="font-family:arial,helvetica,sans-serif">r196926 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196930 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196962 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196963 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196964 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196965 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197066 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197067 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197068 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197090 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197159 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197250 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197402 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200491 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">201091 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre">  </span><span style="font-family:arial,helvetica,sans-serif">r201793 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196834 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196835 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196836 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196927 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196931 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196936 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196966 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196967 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196968 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r196969 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197069 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197070 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197071 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197091 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r197403 </span></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif"> * tnorthover: <span class="" style="white-space:pre">   </span>r200706 </font><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre">      </span><span style="font-family:arial,helvetica,sans-serif">r200768 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200470 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200471 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200472 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200524 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200525 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200526 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200527 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200528 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200707 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200708 </span><span class="" style="font-family:arial,helvetica,sans-serif;white-space:pre"> </span><span style="font-family:arial,helvetica,sans-serif">r200769 </span></div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">and I added them in CC list.<br>
</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">For ABI changes, there are two things I think,</div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">* Some of the patches from Tim merged LLVM IR intrinsic from llvm.aarch64.xxx to llvm.arm.xxx. e.g. 200768.</div>* For AArch64, int64_t is changed from "long long" to "long". C++ name mangling could expose the issue. <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;display:inline">
i.e. </div>202004<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;display:inline">. </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
I've been using:<br>
<a href="http://ispras.linuxbase.org/index.php/ABI_compliance_checker" target="_blank">http://ispras.linuxbase.org/index.php/ABI_compliance_checker</a><br>
to verify ABI consistency when merging patches.  Could you test it out<br>
on your branch?  I think changes like r<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;display:inline"></div>200768 which add or remove<br>
intrinsics in llvm/include/IR will end up breaking the ABI.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">I tried this tool, but I can't make it work yet. The tool requires to use GCC, but the tool can't use gcc 4.8, because gcc has a bug, but building llvm requires to use gcc 4.8 or above, so this is a conflict I have to solve before making it work. So how do you handle this issue when using this tool?</div>
<br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Also, could you please share with me the xml files and command lines you are using for this tool?</div></div><div>
<br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">-Jiangning</div>
<br></div></div>
</div></div>