<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2014-03-25 22:33 GMT+04:00 Reid Kleckner <span dir="ltr"><<a href="mailto:reid@kleckner.net" target="_blank" class="cremed">reid@kleckner.net</a>></span>:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id=":6b0" class="" style="overflow:hidden">--- cfe/trunk/lib/AST/VTableBuilder.cpp (original)<br>


+++ cfe/trunk/lib/AST/VTableBuilder.cpp Tue Mar 25 13:33:27 2014<br>
@@ -3210,6 +3210,8 @@ void MicrosoftVTableContext::computeVTab<br>
     // morally virtual bases.<br>
     for (const auto &I : Base->vbases())<br>
       <span class="">VBasesSeen</span>.insert(I.getType()->getAsCXXRecordDecl());<br>
+    if (I.isVirtual())<br>
+      <span class="">VBasesSeen</span>.insert(Base);<br>
   }</div></blockquote></div><br>Wow, that revealed that we have a variable name shadowing going on here!</div><div class="gmail_extra">Fixed in r204787.</div><div class="gmail_extra"><br></div><div class="gmail_extra">I also kinda think the if() is more logical/readable to go before for().</div>

<div class="gmail_extra">WDYT?</div></div>