<div dir="ltr">Hi,<div><br></div><div>how does one fix this warning? I have this code:</div><div><br></div><div><div> NSString* string = @"";</div><div> [NSThread detachNewThreadSelector:@selector(length)</div>
<div> toTarget:string</div><div> withObject:nil];</div></div><div><br></div><div><br></div><div>clang now warns:</div><div><br></div><div><div>../../content/renderer/renderer_main_platform_delegate_mac.mm:122:39: error: several methods with selector 'length' of mismatched types are found for the @selector expression [-Werror,-Wselector-type-mismatch]</div>
<div> [NSThread detachNewThreadSelector:@selector(length)</div><div> ^</div><div>/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:78:1: note: method 'length' declared here</div>
<div>- (NSUInteger)length; </div><div>^</div><div>/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSStatusItem.h:45:1: note: method 'length' declared here</div>
<div>- (CGFloat)length;</div><div>^</div></div><div><br></div><div>What am I supposed to do about this?</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 12, 2014 at 11:34 AM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br>
Date: Wed Mar 12 13:34:01 2014<br>
New Revision: 203693<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=203693&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=203693&view=rev</a><br>
Log:<br>
Objective-C. Issue diagnostics on mismatched methods when their selector is used<br>
in an @selector expression. // rdar://15794055<br>
<br>
Modified:<br>
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
cfe/trunk/lib/Sema/SemaExprObjC.cpp<br>
cfe/trunk/test/SemaObjC/selector-1.m<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=203693&r1=203692&r2=203693&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=203693&r1=203692&r2=203693&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Wed Mar 12 13:34:01 2014<br>
@@ -892,7 +892,9 @@ def warn_unimplemented_selector: Warnin<br>
InGroup<Selector>, DefaultIgnore;<br>
def warn_unimplemented_protocol_method : Warning<<br>
"method %0 in protocol %1 not implemented">, InGroup<Protocol>;<br>
-<br>
+def warning_multiple_selectors: Warning<<br>
+ "several methods with selector %0 of mismatched types are found for the @selector expression">,<br>
+ InGroup<SelectorTypeMismatch>;<br>
// C++ declarations<br>
def err_static_assert_expression_is_not_constant : Error<<br>
"static_assert expression is not an integral constant expression">;<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=203693&r1=203692&r2=203693&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=203693&r1=203692&r2=203693&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaExprObjC.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaExprObjC.cpp Wed Mar 12 13:34:01 2014<br>
@@ -973,6 +973,58 @@ ExprResult Sema::ParseObjCEncodeExpressi<br>
return BuildObjCEncodeExpression(AtLoc, TInfo, RParenLoc);<br>
}<br>
<br>
+static bool HelperToDiagnoseMismatchedMethodsInGlobalPool(Sema &S,<br>
+ SourceLocation AtLoc,<br>
+ ObjCMethodDecl *Method,<br>
+ ObjCMethodList &MethList) {<br>
+ ObjCMethodList *M = &MethList;<br>
+ bool Warned = false;<br>
+ for (M = M->getNext(); M; M=M->getNext()) {<br>
+ ObjCMethodDecl *MatchingMethodDecl = M->Method;<br>
+ if (MatchingMethodDecl == Method ||<br>
+ isa<ObjCImplDecl>(MatchingMethodDecl->getDeclContext()) ||<br>
+ MatchingMethodDecl->getSelector() != Method->getSelector())<br>
+ continue;<br>
+ if (!S.MatchTwoMethodDeclarations(Method,<br>
+ MatchingMethodDecl, Sema::MMS_loose)) {<br>
+ if (!Warned) {<br>
+ Warned = true;<br>
+ S.Diag(AtLoc, diag::warning_multiple_selectors)<br>
+ << Method->getSelector();<br>
+ S.Diag(Method->getLocation(), diag::note_method_declared_at)<br>
+ << Method->getDeclName();<br>
+ }<br>
+ S.Diag(MatchingMethodDecl->getLocation(), diag::note_method_declared_at)<br>
+ << MatchingMethodDecl->getDeclName();<br>
+ }<br>
+ }<br>
+ return Warned;<br>
+}<br>
+<br>
+static void DiagnoseMismatchedSelectors(Sema &S, SourceLocation AtLoc,<br>
+ ObjCMethodDecl *Method) {<br>
+ unsigned DIAG = diag::warning_multiple_selectors;<br>
+ if (S.Diags.getDiagnosticLevel(DIAG, SourceLocation())<br>
+ == DiagnosticsEngine::Ignored)<br>
+ return;<br>
+ bool Warned = false;<br>
+ for (Sema::GlobalMethodPool::iterator b = S.MethodPool.begin(),<br>
+ e = S.MethodPool.end(); b != e; b++) {<br>
+ // first, instance methods<br>
+ ObjCMethodList &InstMethList = b->second.first;<br>
+ if (HelperToDiagnoseMismatchedMethodsInGlobalPool(S, AtLoc,<br>
+ Method, InstMethList))<br>
+ Warned = true;<br>
+<br>
+ // second, class methods<br>
+ ObjCMethodList &ClsMethList = b->second.second;<br>
+ if (HelperToDiagnoseMismatchedMethodsInGlobalPool(S, AtLoc,<br>
+ Method, ClsMethList) ||<br>
+ Warned)<br>
+ return;<br>
+ }<br>
+}<br>
+<br>
ExprResult Sema::ParseObjCSelectorExpression(Selector Sel,<br>
SourceLocation AtLoc,<br>
SourceLocation SelLoc,<br>
@@ -994,7 +1046,8 @@ ExprResult Sema::ParseObjCSelectorExpres<br>
<br>
} else<br>
Diag(SelLoc, diag::warn_undeclared_selector) << Sel;<br>
- }<br>
+ } else<br>
+ DiagnoseMismatchedSelectors(*this, AtLoc, Method);<br>
<br>
if (!Method ||<br>
Method->getImplementationControl() != ObjCMethodDecl::Optional) {<br>
<br>
Modified: cfe/trunk/test/SemaObjC/selector-1.m<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/selector-1.m?rev=203693&r1=203692&r2=203693&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/selector-1.m?rev=203693&r1=203692&r2=203693&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaObjC/selector-1.m (original)<br>
+++ cfe/trunk/test/SemaObjC/selector-1.m Wed Mar 12 13:34:01 2014<br>
@@ -1,18 +1,17 @@<br>
// RUN: %clang_cc1 -verify %s<br>
-// expected-no-diagnostics<br>
<br>
@interface I<br>
-- (id) compare: (char) arg1;<br>
+- (id) compare: (char) arg1; // expected-note {{method 'compare:' declared here}}<br>
- length;<br>
@end<br>
<br>
@interface J<br>
-- (id) compare: (id) arg1;<br>
+- (id) compare: (id) arg1; // expected-note {{method 'compare:' declared here}}<br>
@end<br>
<br>
SEL func()<br>
{<br>
- return @selector(compare:); // no warning on multiple selector found.<br>
+ return @selector(compare:); // expected-warning {{several methods with selector 'compare:' of mismatched types are found for the @selector expression}}<br>
}<br>
<br>
int main() {<br>
@@ -27,3 +26,26 @@ int main() {<br>
<br>
SEL s9 = @selector(:enum:bool:);<br>
}<br>
+<br>
+// rdar://15794055<br>
+@interface NSObject @end<br>
+<br>
+@class NSNumber;<br>
+<br>
+@interface XBRecipe : NSObject<br>
+@property (nonatomic, assign) float finalVolume; // expected-note {{method 'setFinalVolume:' declared here}}<br>
+@end<br>
+<br>
+@interface XBDocument : NSObject<br>
+@end<br>
+<br>
+@interface XBDocument ()<br>
+- (void)setFinalVolume:(NSNumber *)finalVolumeNumber; // expected-note {{method 'setFinalVolume:' declared here}}<br>
+@end<br>
+<br>
+@implementation XBDocument<br>
+- (void)setFinalVolume:(NSNumber *)finalVolumeNumber<br>
+{<br>
+ (void)@selector(setFinalVolume:); // expected-warning {{several methods with selector 'setFinalVolume:' of mismatched types are found for the @selector expression}}<br>
+}<br>
+@end<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>