<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 24, 2014 at 2:30 PM, Jingyue Wu <span dir="ltr"><<a href="mailto:jingyue@google.com" target="_blank">jingyue@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">

<div class="">On Mon, Mar 24, 2014 at 1:56 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">On Fri, Mar 21, 2014 at 11:20:55AM -0700, Jingyue Wu wrote:<br>


> diff --git a/test/CodeGenCUDA/<a href="http://address-space-conversion.cu" target="_blank">address-space-conversion.cu</a> b/test/CodeGenCUDA/<a href="http://address-space-conversion.cu" target="_blank">address-space-conversion.cu</a><br>



> new file mode 100644<br>
> index 0000000..9b9ae43<br>
> --- /dev/null<br>
> +++ b/test/CodeGenCUDA/<a href="http://address-space-conversion.cu" target="_blank">address-space-conversion.cu</a><br>
<br>
Can these test cases live in <a href="http://address-spaces.cu" target="_blank">address-spaces.cu</a>? They are basically testing<br>
the same thing.<br></blockquote><div><br></div></div><div>Done. Thanks Peter! </div><div class=""><div> </div></div></div></div></div></blockquote><div><br></div><div>Committed in r204677. Thanks for the reviews</div><div>

<br></div><div>Eli</div></div><br></div></div>