<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Actually neither of the checkers from
the 'unix' group are Unix specific. Neither is the majority of
'alpha.unix' group.<br>
<br>
unix.API - not all handled functions are Unix/POSIX specific<br>
open (POSIX)<br>
pthread_once (POSIX)<br>
calloc (ISO C)<br>
malloc (ISO C)<br>
realloc (ISO C)<br>
alloca (4.3 BSD ?)<br>
<br>
unix.Malloc - malloc is a C standard function<br>
<br>
unix.MallocSizeof - malloc is a C standard function<br>
<br>
unix.MismatchedDeallocator - handles C/C++ standard functions<br>
<br>
unix.cstring.BadSizeArg - strncat is a C standard function<br>
<br>
unix.cstring.NullArg - not all handled functions are Unix/POSIX
specific<br>
strlen (ISO C)<br>
strnlen (POSIX)<br>
strcpy (ISO C)<br>
strncpy (ISO C)<br>
strcat (ISO C)<br>
strncat (ISO C)<br>
strcmp (ISO C)<br>
strncmp (ISO C)<br>
strcasecmp (POSIX)<br>
strncasecmp (POSIX)<br>
<br>
alpha.unix.MallocWithAnnotations - malloc is a C standard function<br>
<br>
alpha.unix.SimpleStream - fopen and fclose are a C standard
functions<br>
<br>
alpha.unix.Stream - all handled functions are a C standard or
standard extension functions<br>
<br>
alpha.unix.cstring.BufferOverlap - not all handled functions are
Unix/POSIX specific<br>
memcpy (ISO C)<br>
mempcpy (GNU extension)<br>
<br>
alpha.unix.cstring.NotNullTerminated - all handled functions are a
C standard or standard extension functions<br>
<br>
alpha.unix.cstring.OutOfBounds - all handled functions are a C
standard or standard extension functions<br>
<br>
<br>
<br>
Alltogether only alpha.unix.Chroot and alpha.unix.PthreadLock
remain pure 'unix' checkers.<br>
I intend to create 'generic' and 'alpha.generic' groups and to
move not Unix specific checkers there. OK to move in this
direction?<br>
All this checker rebase activity was inspired by my current work
on the improved lists of actual/alpha/potential checkers.<br>
<br>
<br>
</div>
<blockquote
cite="mid:D9035F7B-8F0A-4108-A696-1398B079E964@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
I’d be fine with breaking ‘core’ into ‘core’ and ‘generic’, which
clearly delineates between built-in functionality that is part of
the analyzer basically doing its job and extensions to that
behavior via the use of opt-in checkers.
<div><br>
<div>
<div>On Mar 19, 2014, at 5:10 PM, Jordan Rose <<a
moz-do-not-send="true" href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space;">
<div>It depends if we want to move existing checkers
around or not. If not, I'm not sure it's worth moving
MismatchedDeallocators from where it is right now. The
"unix" checkers are turned on on all platforms right
now. If we do want to break "core" into "core" and
"generic" then MismatchedDeallocators, along with Malloc
itself, should be moved into "generic" (or whatever we
decide to call it.)</div>
<div><br>
</div>
<div>My inclination is to leave it where it is right now.</div>
<div><br>
</div>
<div>(The reason to move it to cplusplus is to skip the
check in C modes. That'd be correct right now but not in
the future. We may or may not care.)</div>
<div><br>
</div>
<div>Jordan</div>
<div><br>
</div>
<br>
<div>
<div>On Mar 19, 2014, at 17:08, Ted Kremenek <<a
moz-do-not-send="true"
href="mailto:kremenek@apple.com">kremenek@apple.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div style="word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;">You
didn’t really answer my question. What is the right
answer here?
<div><br>
<div>
<div>On Mar 19, 2014, at 2:05 PM, Jordan Rose
<<a moz-do-not-send="true"
href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type"
content="text/html; charset=windows-1252">
<div style="word-wrap: break-word;
-webkit-nbsp-mode: space;
-webkit-line-break: after-white-space;">
<div>"unix" includes an awful lot of generic
things (like malloc itself). Part of the
problem here is that our "core" checkers
are always on. We don't have
"generic-but-not-required" checkers right
now.</div>
<div><br>
</div>
<div>Jordan</div>
<div><br>
</div>
<br>
<div>
<div>On Mar 19, 2014, at 13:55, Ted
Kremenek <<a moz-do-not-send="true"
href="mailto:kremenek@apple.com">kremenek@apple.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type"
content="text/html;
charset=windows-1252">
<div style="word-wrap: break-word;
-webkit-nbsp-mode: space;
-webkit-line-break:
after-white-space;">By that argument,
does it belong in “unix”? What about
Windows-specific allocators?
<div><br>
<div>
<div>On Mar 19, 2014, at 1:45 PM,
Jordan Rose <<a
moz-do-not-send="true"
href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type"
content="text/html;
charset=windows-1252">
<div style="word-wrap:
break-word; -webkit-nbsp-mode:
space; -webkit-line-break:
after-white-space;">
<div>It's <i>currently</i> specific
to C++, but I'm not sure
it's <i>inherently</i> specific
to C++. I can imagine the
FreeBSD guys adding support
for custom C allocators too.
So I'm not sure it's worth
moving.</div>
<div><br>
</div>
<div>Jordan</div>
<div><br>
</div>
<br>
<div>
<div>On Mar 19, 2014, at
13:27, Ted Kremenek <<a
moz-do-not-send="true"
href="mailto:kremenek@apple.com">kremenek@apple.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<blockquote type="cite">Seems
fine to me.<br>
<br>
On Mar 19, 2014, at 1:12
PM, Anton Yartsev <<a
moz-do-not-send="true"
href="mailto:anton.yartsev@gmail.com">anton.yartsev@gmail.com</a>>
wrote:<br>
<br>
<blockquote type="cite">Hi!<br>
<br>
Propose to move the
MismatchedDeallocator
checker from unix.* to
cplusplus.* group if you
don't think it's too
late. This check is
specific for C++.<br>
<br>
-- <br>
Anton<br>
<br>
<MismatchedDeallocator_rebase.patch>_______________________________________________<br>
cfe-commits mailing list<br>
<a
moz-do-not-send="true"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a
moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Anton</pre>
</body>
</html>