<div dir="ltr">I am really not certain about this approach.<div><br></div><div>One of the huge advantages of using target_link_libraries is that it isn't yet-another magical LLVM-customized-CMake-ism that newcomers to the project need to learn and internalize. Instead, they use the boring and expected CMake mechanism for adding a library to the dependencies.</div>
<div><br></div><div>You don't provide *any* justification for this shift in the commit log, you didn't ask for precommit review to gather feedback about this approach, and you haven't replied (that I've seen) to both Rafael and my comments expressing our concern over this approach.</div>
<div><br></div><div>Can we please actually have discussions about the direction for the cmake build prior to making sweeping changes to its architecture?</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Feb 25, 2014 at 10:41 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">Author: chapuni<br>
Date: Wed Feb 26 00:41:29 2014<br>
New Revision: 202238<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=202238&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=202238&view=rev</a><br>
Log:<br>
[CMake] Use LINK_LIBS instead of target_link_libraries().<br>
<br>
Modified:<br>
</div> clang-tools-extra/trunk/clang-apply-replacements/CMakeLists.txt<br>
clang-tools-extra/trunk/clang-modernize/Core/CMakeLists.txt<br>
clang-tools-extra/trunk/clang-query/CMakeLists.txt<br>
clang-tools-extra/trunk/clang-tidy/CMakeLists.txt<br>
clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt<br>
clang-tools-extra/trunk/clang-tidy/llvm/CMakeLists.txt<br>
<br>
Modified: clang-tools-extra/trunk/clang-apply-replacements/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-apply-replacements/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-apply-replacements/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-apply-replacements/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-apply-replacements/CMakeLists.txt Wed Feb 26 00:41:29 2014<br>
@@ -4,8 +4,8 @@ set(LLVM_LINK_COMPONENTS<br>
<br>
add_clang_library(clangApplyReplacements<br>
lib/Tooling/ApplyReplacements.cpp<br>
- )<br>
-target_link_libraries(clangApplyReplacements<br>
+<br>
+ LINK_LIBS<br>
clangBasic<br>
clangRewriteCore<br>
clangTooling<br>
<br>
Modified: clang-tools-extra/trunk/clang-modernize/Core/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/Core/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/Core/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-modernize/Core/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-modernize/Core/CMakeLists.txt Wed Feb 26 00:41:29 2014<br>
@@ -7,8 +7,8 @@ add_clang_library(modernizeCore<br>
IncludeExcludeInfo.cpp<br>
PerfSupport.cpp<br>
IncludeDirectives.cpp<br>
- )<br>
-target_link_libraries(modernizeCore<br>
<div class="">+<br>
+ LINK_LIBS<br>
clangAST<br>
clangASTMatchers<br>
clangBasic<br>
<br>
</div>Modified: clang-tools-extra/trunk/clang-query/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-query/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-query/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-query/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-query/CMakeLists.txt Wed Feb 26 00:41:29 2014<br>
@@ -6,8 +6,8 @@ set(LLVM_LINK_COMPONENTS<br>
add_clang_library(clangQuery<br>
Query.cpp<br>
QueryParser.cpp<br>
- )<br>
-target_link_libraries(clangQuery<br>
<div class="">+<br>
+ LINK_LIBS<br>
clangAST<br>
clangASTMatchers<br>
clangBasic<br>
<br>
</div>Modified: clang-tools-extra/trunk/clang-tidy/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/CMakeLists.txt Wed Feb 26 00:41:29 2014<br>
@@ -9,8 +9,8 @@ add_clang_library(clangTidy<br>
<br>
DEPENDS<br>
ClangSACheckers<br>
- )<br>
-target_link_libraries(clangTidy<br>
<div class="">+<br>
+ LINK_LIBS<br>
clangAST<br>
clangASTMatchers<br>
clangBasic<br>
<br>
</div>Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt Wed Feb 26 00:41:29 2014<br>
@@ -2,8 +2,8 @@ set(LLVM_LINK_COMPONENTS support)<br>
<br>
add_clang_library(clangTidyGoogleModule<br>
GoogleTidyModule.cpp<br>
- )<br>
-target_link_libraries(clangTidyGoogleModule<br>
<div class="">+<br>
+ LINK_LIBS<br>
clangAST<br>
clangASTMatchers<br>
clangBasic<br>
<br>
</div>Modified: clang-tools-extra/trunk/clang-tidy/llvm/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/llvm/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/llvm/CMakeLists.txt?rev=202238&r1=202237&r2=202238&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/llvm/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/llvm/CMakeLists.txt Wed Feb 26 00:41:29 2014<br>
@@ -2,8 +2,8 @@ set(LLVM_LINK_COMPONENTS support)<br>
<br>
add_clang_library(clangTidyLLVMModule<br>
LLVMTidyModule.cpp<br>
- )<br>
-target_link_libraries(clangTidyLLVMModule<br>
<div class="HOEnZb"><div class="h5">+<br>
+ LINK_LIBS<br>
clangAST<br>
clangASTMatchers<br>
clangBasic<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>