<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Clang commits is a little slow today. It hasn’t shown up in my inbox yet, but I see that it is currently compiling.<div><br><div><div>On Feb 20, 2014, at 4:07 PM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Should have been fixed by r201825.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 20, 2014 at 3:54 PM, Juergen Ributzka <span dir="ltr"><<a href="mailto:juergen@apple.com" target="_blank">juergen@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On of your recent pragma changes broke our internal build.<br>
<br>
******************** TEST 'Clang Tools :: pp-trace/pp-trace-pragma-ms.cpp' FAILED ********************<br>
Script:<br>
--<br>
pp-trace -ignore FileChanged,MacroDefined src/tools/clang/tools/extra/test/pp-trace/pp-trace-pragma-ms.cpp -target x86_64 -fms-extensions -w | FileCheck --strict-whitespace src/tools/clang/tools/extra/test/pp-trace/pp-trace-pragma-ms.cpp<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
src/tools/clang/tools/extra/test/pp-trace/pp-trace-pragma-ms.cpp:23:16: error: expected string not found in input<br>
// CHECK-NEXT: - Callback: PragmaComment<br>
^<br>
<stdin>:5:1: note: scanning from here<br>
- Callback: PragmaDirective<br>
^<br>
<br>
Could you please take a look?<br>
<br>
Thanks<br>
<br>
Cheers,<br>
Juergen<br>
<div><div class="h5"><br>
On Feb 20, 2014, at 2:59 PM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br>
<br>
><br>
> Closed by commit rL201820 (authored by @rnk).<br>
><br>
> CHANGED PRIOR TO COMMIT<br>
> <a href="http://llvm-reviews.chandlerc.com/D2834?vs=7219&id=7260#toc" target="_blank">http://llvm-reviews.chandlerc.com/D2834?vs=7219&id=7260#toc</a><br>
><br>
> <a href="http://llvm-reviews.chandlerc.com/D2834" target="_blank">http://llvm-reviews.chandlerc.com/D2834</a><br>
><br>
> COMMIT<br>
> <a href="http://llvm-reviews.chandlerc.com/rL201820" target="_blank">http://llvm-reviews.chandlerc.com/rL201820</a><br>
</div></div>> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>