<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 13, 2014, at 7:57 , NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">One-point nitpick; Did you really need to add dependencies to these libraries?</span><br style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></blockquote></div><br><div>I thought about this. Since we don't link to any of these libraries, we <i>shouldn't</i> need them. But then I thought we'd want to recompile this plugin if any of them changed. However, today I realized CMake should already be looking at the header files as dependencies (by scanning includes), so I can probably drop them.</div><div><br></div><div><blockquote type="cite"><span style="font-family: Monaco; font-size: 10px;">I guess you would like ClangCommentCommandList here.</span><br style="font-family: Monaco; font-size: 10px;"></blockquote></div><div><span style="font-family: Monaco; font-size: 10px;"><br></span></div><div>Good point. This is the template for any future checker plugins, including ones that look at comments. I'll fix both of these issues.</div><div><br></div><div>Thanks!</div><div>Jordan</div></body></html>