<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 11, 2014, at 9:40 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 11, 2014 at 8:20 AM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><div>On Feb 11, 2014, at 2:16 AM, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">Very cool. A few high level questions:<div>- shouldn't the virtual file system go into llvm, not clang?<br></div></div></blockquote><div><br></div></div><div>I’m fine with putting this in llvm/Support instead of clang/Basic, but we’ll need to check with llvm-dev and the libsupport code owner. If you feel strongly about this I’ll send something to Chandler and llvm-dev.</div>
</blockquote></div><br>So, one point: code owners don't have a "yes" or "no" to say to something. We just are responsible for finding a code reviewer if one doesn't show up to review a patch.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">That said, my suggestion is actually to get a good abstraction that you think *could* move productively to the LLVM support library but is easier to iterate on in clang/Basic. When you think it's looking good, maybe send it then?</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">I just don't want to slow down the reviews with questions like -- how would LLD use this? How would it interact with X, Y, and Z use case that you don't (currently) have?</div>
</div>
</blockquote></div><br><div>+1, let’s iterate more and have it “battle tested” on clang before we hoist it on llvm.</div></body></html>