<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 11, 2014, at 1:24 PM, Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com">kyrtzidis@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline">On Feb 11, 2014, at 1:13 PM, Ben Langmuir <<a href="mailto:blangmuir@apple.com">blangmuir@apple.com</a>> wrote:</div><br class="Apple-interchange-newline" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>On Feb 11, 2014, at 12:23 PM, Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com">kyrtzidis@apple.com</a>> wrote:<br><br><blockquote type="cite">On Feb 10, 2014, at 2:32 PM, Ben Langmuir <<a href="mailto:blangmuir@apple.com">blangmuir@apple.com</a>> wrote:<br><br><blockquote type="cite">Hi Doug et al.<br><br>This is the first patch in the implementation of the virtual file system discussed here:<span class="Apple-converted-space"> </span><a href="http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-February/035188.html">http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-February/035188.html</a>. It is intended to include enough of the AbstractFileSystem interface to replace the use of llvm::sys::fs in FileManager. Incidentally, I’ve included a number of the convenience methods that are trivially implemented on top of the status object. When created by the CompilerInstance, FileManager will use a virtual file system created by the CI, but to avoid modifying every other user of the FileManager, in the absence of an explicit AbstractFileSystem to use, it will default to the real file system during construction.<br><br>Additionally, I’ve included a stub implementation of the OverlayFileSystem, which the CompilerInstance uses. It is able to overlay files from a second file system, but will not merge directories correctly yet. There are no users that actually push a second file system yet (other than the included unit test).<br><br>This patch is notably missing: the interfaces for recursive directory traversal, file system modification (create dir, rename, etc.), and any notion of thread safety.<br><br>Ben<br><br><vfs-part1.patch><br><br></blockquote><br><br>Looks good!<span class="Apple-converted-space"> </span><br><br>To add on the nitpicking.. :-)<br><br>+ /// In addition to providing the usual stat information, this class provides<br>+ /// \p Name and \p RealName fields, which can be used by clients that need<br>+ /// to differentiate between the name that this object was looked up by,<br>+ /// and the real name of this object on disk (if there is one).<br><br>Could you clarify what should happen if there is no real path (it's a virtual file), is RealName == Name or is it empty ?<br></blockquote><br>RealName == “”<br></div></blockquote><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hmm, if we do RealName == Name it will simplify a bit the clients that care (e.g. what to put in FileEntry), they will just use RealName, instead of doing </div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="Apple-tab-span" style="white-space: pre;"> </span>if (!RealName.empty())</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> use(RealName)</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> else</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> use(Name)</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">vs</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> use(RealName)</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">We could have another way to determine if the file is virtual or not, if there is a client that may care.</div></blockquote><div><br></div>Yes, I think this has shown that trying to use names to differentiate virtual/non-virtual is a bad idea. I’m going to change RealName to ExternalName, meaning: this is the name you should use to refer to this file externally, such as in diagnostics and debug info. Then to be explicit:</div><div><br></div><div>1) real file: Name == ExternalName (and ExternalName exists on disk)</div><div>2) fully virtual file: Name == ExternalName (and ExternalName does *not* exist on disk)</div><div>3) virtual link to real file: Name != ExternalName (and ExternalName exists on disk)</div><div><br></div><div>As you say, we can add a bit if we ever actually want to differentiate 1 and 2.</div><div><br><blockquote type="cite"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>I’ll update the comment.<br><br><blockquote type="cite"><br><br><blockquote type="cite"><blockquote type="cite"><br>I just thought that we might need to resolve symlinks ourselves,<br>here's why. Suppose that we have a real FS:<br><br>/foo<br>/foo/bar/bar.h<br>/foo/baz/baz.h -> symlink to ../bar/bar.h<br><br>Then we push an overlay over /foo/bar. If we rely on OS-level open(),<br>then opening baz/baz.h will open bar.h from the real FS, but it is<br>hidden by the overlay, thus we have an inconsistency.<br></blockquote><br>Good catch. It looks like the overlay file system will need to stat every path prefix and then resolve links itself when it finds them. That’s unpleasant, but doable. Looks like we’ll need to add a read link function to sys::fs… which might be a pain on Windows. I’m reading the documentation on Windows file system reparse points, and it’s not nearly as easy as calling ::readlink.<br></blockquote><br>I'm concerned about the performance implications of stat'ing everything and trying to resolve symlinks, and I'm not sure how bad the issue will be in practice.<br>Could we defer investigating into this for after we have the simpler case working ?<br></blockquote><br>With caching I don’t think the performance will be a big problem, but we will have to see. I’m fine with deferring this.<br><br><blockquote type="cite"><br>On a related note, what about using a filename with different casing from what it was declared in the vfs ('myfoo.h' vs 'MyFoo.h').<br><br></blockquote><br><br>Since the overlay defers to other file systems, I don’t think it needs to care. When we add a file system for vfs files, we probably need an option to do case-insensitive matching. I’m not sure if that is a property of the host or just a property of the filesystem though…<br></div></blockquote><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">To clarify, I was asking about what the “virtual layout” implementation is going to do. Maybe have case-insensitive or not be an optional parameter, but if that parameter is not set, use as default case-insensitive on Darwin and case-sensitive on linux.</div></blockquote><div><br></div>Sounds good to me.<br><br><blockquote type="cite"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>Ben</div></blockquote></blockquote></div><br></body></html>