<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>If you want to see what I tried, it was r190557, but that ended up getting reverted in r191784. I don't think I had the right approach, though.</div><div><br></div><div>The general problem is that CMake steps only run at configure time, which means if no CMakeLists are changed the repository version wouldn't generally get updated. In my patch I changed things to check the repository version every time, but that was expensive. (Still, it's no different from what the Makefile build does, right?)</div><div><br></div><div>Jordan</div><div><br></div><br><div><div>On Feb 9, 2014, at 13:44 , Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Note that the clang side is totally hosed here compared to the LLVM side. Compare the CMake code in Clang to VersionFromVCS.cmake which can handle subversion, git, and git-svn gracefully. I can't even really test these patches because clang gives up (i think) when it fails to find a .svn directory.<div>
<br></div><div>I think it would be better to switch clang to use VersionFromVCS.cmake and then consolidate improvements there.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Feb 9, 2014 at 1:08 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sun, Feb 9, 2014 at 7:25 PM, Kim Gräsman <<a href="mailto:kim.grasman@gmail.com">kim.grasman@gmail.com</a>> wrote:<br>
> ping.<br>
<br>
+ Jordan, who was working on this part of code recently, if I recall correctly.<br>
<span class="HOEnZb"><font color="#888888"><br>
Dmitri<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div><br></body></html>