<p dir="ltr">Ted, what's your opinion? Is it fine to commit the patch as is?</p>
<div class="gmail_quote">On 3 Feb 2014 20:26, "Alexander Kornienko" <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
CheckerName -> CheckName + fixed a comment.<br>
<br>
Hi jordan_rose, krememek,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2557" target="_blank">http://llvm-reviews.chandlerc.com/D2557</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
<a href="http://llvm-reviews.chandlerc.com/D2557?vs=6747&id=6830#toc" target="_blank">http://llvm-reviews.chandlerc.com/D2557?vs=6747&id=6830#toc</a><br>
<br>
Files:<br>
examples/analyzer-plugin/MainCallChecker.cpp<br>
include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h<br>
include/clang/StaticAnalyzer/Core/BugReporter/BugType.h<br>
include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h<br>
include/clang/StaticAnalyzer/Core/Checker.h<br>
include/clang/StaticAnalyzer/Core/CheckerManager.h<br>
lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp<br>
lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp<br>
lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp<br>
lib/StaticAnalyzer/Checkers/CStringChecker.cpp<br>
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp<br>
lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp<br>
lib/StaticAnalyzer/Checkers/CastSizeChecker.cpp<br>
lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp<br>
lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp<br>
lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp<br>
lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp<br>
lib/StaticAnalyzer/Checkers/CheckSizeofPointer.cpp<br>
lib/StaticAnalyzer/Checkers/ChrootChecker.cpp<br>
lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp<br>
lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp<br>
lib/StaticAnalyzer/Checkers/DirectIvarAssignment.cpp<br>
lib/StaticAnalyzer/Checkers/DivZeroChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp<br>
lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp<br>
lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp<br>
lib/StaticAnalyzer/Checkers/IdenticalExprChecker.cpp<br>
lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp<br>
lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp<br>
lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp<br>
lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp<br>
lib/StaticAnalyzer/Checkers/MallocChecker.cpp<br>
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp<br>
lib/StaticAnalyzer/Checkers/MallocSizeofChecker.cpp<br>
lib/StaticAnalyzer/Checkers/NSAutoreleasePoolChecker.cpp<br>
lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp<br>
lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp<br>
lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ObjCAtSyncChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ObjCContainersASTChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ObjCContainersChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ObjCMissingSuperCallChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp<br>
lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp<br>
lib/StaticAnalyzer/Checkers/PointerSubChecker.cpp<br>
lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp<br>
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ReturnPointerRangeChecker.cpp<br>
lib/StaticAnalyzer/Checkers/ReturnUndefChecker.cpp<br>
lib/StaticAnalyzer/Checkers/SimpleStreamChecker.cpp<br>
lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp<br>
lib/StaticAnalyzer/Checkers/StreamChecker.cpp<br>
lib/StaticAnalyzer/Checkers/TaintTesterChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UndefBranchChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UndefCapturedBlockVarChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UndefinedArraySubscriptChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp<br>
lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp<br>
lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp<br>
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp<br>
lib/StaticAnalyzer/Core/BugReporter.cpp<br>
lib/StaticAnalyzer/Core/Checker.cpp<br>
lib/StaticAnalyzer/Core/CheckerRegistry.cpp<br>
lib/StaticAnalyzer/Core/PathDiagnostic.cpp<br>
</blockquote></div>