<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Feb 3, 2014 at 7:44 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im">On Mon, Feb 3, 2014 at 7:41 PM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Mon, Feb 3, 2014 at 7:34 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Mon, Feb 3, 2014 at 7:30 PM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Could you mark it 'accepted' in Phabricator? <a href="http://llvm-reviews.chandlerc.com/D2556" target="_blank">http://llvm-reviews.chandlerc.com/D2556</a></div>
</blockquote><div><br></div></div><div>There is no need for anybody to mark anything in phab :) LG on the mailing list is enough...</div></div></div></div></blockquote><div><br></div></div><div>Sure there's no need. I just use Phab's arcanist tool, which needs less explanations when committing an accepted patch. So it's better when the status is updated in Phab, if it doesn't inconvenience the reviewer.</div>
</div></div></div></blockquote><div><br></div></div><div>For exactly that reason we got "self accept" implemented upstream, so if you get an LG on the mailing list, you can just self-accept and submit via arc...</div>
</div></div></div></blockquote><div><br></div><div>Oh, or was that "self close"? In that case, we can get self accept implemented, too :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><br></div><div>Thanks!</div><div><div><div><div class="gmail_extra">
<br><div class="gmail_quote">On Mon, Feb 3, 2014 at 7:01 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><br><div><div>On Jan 30, 2014, at 16:34 , Alexander Kornienko <<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>> wrote:</div><br><blockquote type="cite">
<blockquote class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word">But maybe I'm just worried about people doing this in general, and shouldn't worry about the specific case of clang-tidy, which will probably get these answers right and be able to evolve with the analyzer core. Still, once Pandora's Box is opened, it can't easily be closed again, and we'd really like external consumers of path diagnostics to build tools that consume a standard output format rather than needing a custom build of Clang to do it.</div>
</blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
The difference between a tool statically linked with clang and a standalone tool consuming analyzer's output in some format is huge, and I don't think sane people would choose the former, if they only need to consumer analyzer's output in some form.</div>
</blockquote></div><br></div><div>All right, you've convinced me. I'll take a look at the names patch, but this one is fine. Let's get more analyzer users! :-)</div><span><font color="#888888"><div><br>
</div><div>Jordan</div></font></span></div></blockquote></div>
</div></div></div></div></div>
</blockquote></div></div></div></div></div></blockquote></div></div><br>
</div></div>
</blockquote></div></div><br></div></div>
</blockquote></div><br></div></div>