<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 29, 2014 at 8:46 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Wed, Jan 29, 2014 at 12:33 AM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rjmccall<br>
Date: Wed Jan 29 02:33:09 2014<br>
New Revision: 200380<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=200380&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=200380&view=rev</a><br>
Log:<br>
Short-circuit a couple of queries (and avoid corrupting<br>
the linkage cache) when type-checking static local<br>
variables.<br></blockquote><div><span style="color:rgb(34,34,34)"> </span><br></div></div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im"><div></div></div><div>Any chance of a test case or two?</div></div></div></div></blockquote><div><br></div><div>Clearly not my day... carry on.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
There's a very deep problem here where the linkage of<br>
a declaration can suddenly massively change as soon as<br>
it's given a typedef name; these fixes, while optimizations<br>
in their own right, are really just targeted workarounds.<br>
<br>
rdar://15928125<br>
<br>
Modified:<br>
cfe/trunk/lib/Sema/SemaDecl.cpp<br>
cfe/trunk/test/SemaCXX/linkage.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=200380&r1=200379&r2=200380&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=200380&r1=200379&r2=200380&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaDecl.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaDecl.cpp Wed Jan 29 02:33:09 2014<br>
@@ -8773,7 +8773,13 @@ void Sema::CheckCompleteVariableDeclarat<br>
}<br>
}<br>
<br>
+ // Warn about externally-visible variables being defined without a<br>
+ // prior declaration. We only want to do this for global<br>
+ // declarations, but we also specifically need to avoid doing it for<br>
+ // class members because the linkage of an anonymous class can<br>
+ // change if it's later given a typedef name.<br>
if (var->isThisDeclarationADefinition() &&<br>
+ var->getDeclContext()->getRedeclContext()->isFileContext() &&<br>
var->isExternallyVisible() && var->hasLinkage() &&<br>
getDiagnostics().getDiagnosticLevel(<br>
diag::warn_missing_variable_declarations,<br>
@@ -8910,7 +8916,7 @@ Sema::FinalizeDeclaration(Decl *ThisDecl<br>
const DeclContext *DC = VD->getDeclContext();<br>
// If there's a #pragma GCC visibility in scope, and this isn't a class<br>
// member, set the visibility of this variable.<br>
- if (!DC->isRecord() && VD->isExternallyVisible())<br>
+ if (DC->getRedeclContext()->isFileContext() && VD->isExternallyVisible())<br>
AddPushedVisibilityAttribute(VD);<br>
<br>
if (VD->isFileVarDecl())<br>
<br>
Modified: cfe/trunk/test/SemaCXX/linkage.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/linkage.cpp?rev=200380&r1=200379&r2=200380&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/linkage.cpp?rev=200380&r1=200379&r2=200380&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/linkage.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/linkage.cpp Wed Jan 29 02:33:09 2014<br>
@@ -103,3 +103,13 @@ namespace test5 {<br>
};<br>
}<br>
}<br>
+<br>
+// Test that we don't compute linkage too hastily before we're done<br>
+// processing a record decl. rdar://15928125<br>
+namespace test6 {<br>
+ typedef struct {<br>
+ void foo() {<br>
+ static int bar = 0;<br>
+ }<br>
+ } A;<br>
+}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>