<div dir="ltr"><div>Thanks for your comments, Alp.</div><div>Regarding the static / global issue, I agree and I will try to take care of it.</div><div><br></div><div>@Stephen, Andrei</div><div>What are your opinionson <span style="font-family:arial,sans-serif;font-size:13px">un-seeded / non-deterministic compilation?</span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">PS: Our discussion does not get aggregated here: </span><font face="arial, sans-serif"><a href="http://llvm-reviews.chandlerc.com/D1803">http://llvm-reviews.chandlerc.com/D1803</a></font></div>
<div><span style="font-family:arial,sans-serif;font-size:13px">Did I do something wrong? How can we change that?</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br>
</span></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 22, 2014 at 3:50 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Stephen,<br>
<br>
I've looked a bit closer at the clang patch.<br>
<br>
I don't understand why this is global:<br>
<br>
llvm::RandomNumberGenerator::<u></u>SetSalt(SaltString);<br>
<br>
LLVM and clang have a strict library design so this would be unreliable for anything other than the simplest single-threaded sequential use modes.<br>
<br>
We're getting close to fixing the last remaining statics so it doesn't seem right to introduce a new one.<span class="HOEnZb"><font color="#888888"><br>
<br>
Alp.</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<br>
On 22/01/2014 23:39, Alp Toker wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 22/01/2014 23:17, Stephen Crane wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Here's the patch for LLVM: <a href="http://llvm-reviews.chandlerc.com/D1802" target="_blank">http://llvm-reviews.chandlerc.<u></u>com/D1802</a> We ended up basing the RNG on the already integrated implementation of MD5, to avoid any external dependencies. We are really just waiting on review of the LLVM patch now that Julian has modified a few things to take care of a performance concern.<br>
</blockquote>
<br>
That sounds good.<br>
<br>
David Majnemer has already done preliminary review of the clang patch and it looks sane to me.<br>
<br>
It will additionally need user documentation explaining the purpose of the feature and noting that stability is not guaranteed between different revisions of the compiler, even with the same seed.<br>
<br>
It's my opinion that un-seeded / non-deterministic compilation shouldn't be supported at all. If that isn't the case already would it be reasonable change for you to accommodate?<br>
<br>
Apart from that, just blocked on the LLVM changes.<br>
<br>
Alp.<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
- stephen<br>
<br>
<br>
On Wed, Jan 22, 2014 at 3:00 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
The clang side looks fine, but there's very little context as to<br>
what's going on here so not possible to review it just like that.<br>
<br>
The patch rebases to clang ToT fine but doesn't build due to<br>
missing RNG facilities in LLVM -- could you give a refresher of<br>
the status of that with a link? It's been long enough that not<br>
everyone remembers the discussion.<br>
<br>
The last I remember of the discussion was that linking to OpenSSL<br>
can be painful, and it doesn't feel right as a dependency. What<br>
are the other options for pseudo RNG and could we have a simpler<br>
scheme?<br>
<br>
That'll help get things moving.<br>
<br>
Alp.<br>
<br>
<br>
<br>
On 22/01/2014 21:48, Julian Lettner wrote:<br>
<br>
Is there anything stopping this from going forward?<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1803" target="_blank">http://llvm-reviews.chandlerc.<u></u>com/D1803</a><br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br>
-- <a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div>