<div dir="ltr">Nice!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 16, 2014 at 7:21 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alp<br>
Date: Thu Jan 16 21:21:54 2014<br>
New Revision: 199455<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=199455&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=199455&view=rev</a><br>
Log:<br>
Make -verify a -cc1 NoDriverOption<br>
<br>
'%clang -verify' will now issue an error instead of succeeding without<br>
verification. This should catch flawed tests like r199347.<br>
<br>
Followup to r199451.<br>
<br>
Added:<br>
    cfe/trunk/test/Misc/driver-verify.c<br>
Modified:<br>
    cfe/trunk/include/clang/Driver/CC1Options.td<br>
    cfe/trunk/include/clang/Driver/Options.td<br>
<br>
Modified: cfe/trunk/include/clang/Driver/CC1Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=199455&r1=199454&r2=199455&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=199455&r1=199454&r2=199455&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/Driver/CC1Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/CC1Options.td Thu Jan 16 21:21:54 2014<br>
@@ -254,6 +254,8 @@ def fconstexpr_backtrace_limit : Separat<br>
   HelpText<"Set the maximum number of entries to print in a constexpr evaluation backtrace (0 = no limit).">;<br>
 def fmessage_length : Separate<["-"], "fmessage-length">, MetaVarName<"<N>">,<br>
   HelpText<"Format message diagnostics so that they fit within N columns or fewer, when possible.">;<br>
+def verify : Flag<["-"], "verify">,<br>
+  HelpText<"Verify diagnostic output using comment directives">;<br>
 def Wno_rewrite_macros : Flag<["-"], "Wno-rewrite-macros">,<br>
   HelpText<"Silence ObjC rewriting warnings">;<br>
<br>
<br>
Modified: cfe/trunk/include/clang/Driver/Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=199455&r1=199454&r2=199455&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=199455&r1=199454&r2=199455&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/Driver/Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/Options.td Thu Jan 16 21:21:54 2014<br>
@@ -1295,8 +1295,6 @@ def unexported__symbols__list : Separate<br>
 def u : JoinedOrSeparate<["-"], "u">, Group<u_Group>;<br>
 def v : Flag<["-"], "v">, Flags<[CC1Option]>,<br>
   HelpText<"Show commands to run and use verbose output">;<br>
-def verify : Flag<["-"], "verify">, Flags<[CC1Option]>,<br>
-  HelpText<"Verify diagnostic output using comment directives">;<br>
 def verify_debug_info : Flag<["--"], "verify-debug-info">, Flags<[DriverOption]>,<br>
   HelpText<"Verify the binary representation of debug output">;<br>
 def weak_l : Joined<["-"], "weak-l">, Flags<[LinkerInput]>;<br>
<br>
Added: cfe/trunk/test/Misc/driver-verify.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/driver-verify.c?rev=199455&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/driver-verify.c?rev=199455&view=auto</a><br>

==============================================================================<br>
--- cfe/trunk/test/Misc/driver-verify.c (added)<br>
+++ cfe/trunk/test/Misc/driver-verify.c Thu Jan 16 21:21:54 2014<br>
@@ -0,0 +1,6 @@<br>
+// RUN: not %clang %s -verify 2>&1 | FileCheck %s<br>
+// RUN: %clang -cc1 -verify %s<br>
+// expected-no-diagnostics<br>
+<br>
+// Test that -verify is strictly rejected as unknown by the driver.<br>
+// CHECK: unknown argument: '-verify'<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>