<div>On Tue Jan 14 2014 at 2:57:29 PM, Alp Toker <<a href="mailto:alp@nuanti.com">alp@nuanti.com</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<br>
<div>On 14/01/2014 22:05, Richard Smith
wrote:<br>
</div>
<blockquote type="cite">
<div>Well:</div>
<div>1) the context is an "incompatible with C++98" diagnostic</div>
<div>2) we really don't need to worry about theoretical future C17
or OpenMP constructs now; we can easily change our diagnostics
if we ever support those things</div>
</blockquote>
<br></div><div bgcolor="#FFFFFF" text="#000000">
Sorry, I didn't mention -- the diag clarification change was split
out from the C11 attributes extension I'd promised to help Renato
with for his 'vectorize' attribute.<br>
<br>
Having split this part out as an unrelated change may have
inadvertently lost some of the context as to why it was useful :-)</div><div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<blockquote type="cite">
<div>3) we have the '[[' in the snippet</div>
<div>4) a %select is *better* than a single fixed string if it
makes the diagnostic clearer</div>
<div><br>
</div>
<div>I'm fine with "'[[...]]' attributes" or similar, although it
seems a little redundant given (3). "C++ attributes" or "C++11
attributes" work for me.</div>
</blockquote>
<br></div><div bgcolor="#FFFFFF" text="#000000">
"C++11 attributes" works in this scenario if you want to go ahead
and change it, but let's keep options open to go back on that,
because it looks a little silly alongside the C11 version:<br></div></blockquote><div><br></div><div>OK, I went ahead with this in r199443. Seems we don't need to worry about the C11 version for the time being, and we retain the option to reword this diagnostic later.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
<code>def ext_cxx11_attribute_in_c : ExtWarn<</code><code><br>
</code><code> "generalized attributes are a non-standard C
extension">, InGroup<CXXAttributes>;</code><br>
<br>
<br>
I'll throw up the full patch in a bit.</div><div bgcolor="#FFFFFF" text="#000000"><br>
<br>
Alp.</div><div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<br>
<pre cols="72">--
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a>
the browser experts
</pre>
</div></blockquote>