<div dir="ltr">Nice!  It wasn't even a bug in MS ABI code.  :)</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 16, 2014 at 4:02 AM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Thu Jan 16 06:02:55 2014<br>
New Revision: 199374<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=199374&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=199374&view=rev</a><br>
Log:<br>
Sema: Fix crash during member pointer conversion involving incomplete classes<br>
<br>
We would attempt to determine the inheritance relationship between<br>
classes 'A' and 'B' during static_cast if we tried to convert from 'int<br>
A::*' to 'int B::*'.  However, the question "does A derive from B" is<br>
not meaningful when 'A' isn't defined.<br>
<br>
Handle this case by requiring that 'A' be defined.<br>
<br>
This fixes PR18506.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaCast.cpp<br>
    cfe/trunk/test/SemaCXX/static-cast.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaCast.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCast.cpp?rev=199374&r1=199373&r2=199374&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCast.cpp?rev=199374&r1=199373&r2=199374&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaCast.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaCast.cpp Thu Jan 16 06:02:55 2014<br>
@@ -1346,7 +1346,8 @@ TryStaticMemberPointerUpcast(Sema &Self,<br>
   QualType DestClass(DestMemPtr->getClass(), 0);<br>
   CXXBasePaths Paths(/*FindAmbiguities=*/true, /*RecordPaths=*/true,<br>
                   /*DetectVirtual=*/true);<br>
-  if (!Self.IsDerivedFrom(SrcClass, DestClass, Paths)) {<br>
+  if (Self.RequireCompleteType(OpRange.getBegin(), SrcClass, 0) ||<br>
+      !Self.IsDerivedFrom(SrcClass, DestClass, Paths)) {<br>
     return TC_NotApplicable;<br>
   }<br>
<br>
<br>
Modified: cfe/trunk/test/SemaCXX/static-cast.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/static-cast.cpp?rev=199374&r1=199373&r2=199374&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/static-cast.cpp?rev=199374&r1=199373&r2=199374&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/SemaCXX/static-cast.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/static-cast.cpp Thu Jan 16 06:02:55 2014<br>
@@ -9,6 +9,8 @@ struct F : public C1 {};            // S<br>
 struct G1 : public B {};<br>
 struct G2 : public B {};<br>
 struct H : public G1, public G2 {}; // Ambiguous path to B.<br>
+struct I;                           // Incomplete.<br>
+struct J;                           // Incomplete.<br>
<br>
 enum Enum { En1, En2 };<br>
 enum Onom { On1, On2 };<br>
@@ -131,6 +133,7 @@ void t_529_9()<br>
   // Bad code below<br>
   (void)static_cast<int A::*>((int H::*)0); // expected-error {{ambiguous conversion from pointer to member of derived class 'H' to pointer to member of base class 'A':}}<br>
   (void)static_cast<int A::*>((int F::*)0); // expected-error {{conversion from pointer to member of class 'F' to pointer to member of class 'A' via virtual base 'B' is not allowed}}<br>
+  (void)static_cast<int I::*>((int J::*)0); // expected-error {{static_cast from 'int J::*' to 'int I::*' is not allowed}}<br>
 }<br>
<br>
 // PR 5261 - static_cast should instantiate template if possible<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>