<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 14, 2014, at 2:01 PM, Sean Silva <<a href="mailto:silvas@purdue.edu">silvas@purdue.edu</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><a href="http://llvm.org/docs/CodingStandards.html#commenting">http://llvm.org/docs/CodingStandards.html#commenting</a><br><div><br></div>"When writing comments, write them as English prose, which means they should use proper capitalization, punctuation, etc. “</div></blockquote>In r<span style="font-family: Menlo; font-size: 11px;">199258.</span></div><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font></div><div><font face="Menlo"><span style="font-size: 11px;">- Fariborz</span></font></div><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font><blockquote type="cite"><div dir="ltr">
<br>-- Sean Silva</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jan 14, 2014 at 4:33 PM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br>
Date: Tue Jan 14 15:33:54 2014<br>
New Revision: 199257<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=199257&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=199257&view=rev</a><br>
Log:<br>
ObjectiveC. add comment.<br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/CGObjCMac.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=199257&r1=199256&r2=199257&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=199257&r1=199256&r2=199257&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Tue Jan 14 15:33:54 2014<br>
@@ -4293,14 +4293,14 @@ llvm::Value *CGObjCMac::EmitIvarOffset(C<br>
/// unsigned flags;<br>
/// };<br>
enum ImageInfoFlags {<br>
- eImageInfo_FixAndContinue = (1 << 0),<br>
+ eImageInfo_FixAndContinue = (1 << 0), // no longer set by clang<br>
eImageInfo_GarbageCollected = (1 << 1),<br>
eImageInfo_GCOnly = (1 << 2),<br>
- eImageInfo_OptimizedByDyld = (1 << 3), // FIXME: When is this set.<br>
+ eImageInfo_OptimizedByDyld = (1 << 3), // set by the dyld shared cache<br>
<br>
// A flag indicating that the module has no instances of a @synthesize of a<br>
// superclass variable. <<a href="rdar://problem/6803242">rdar://problem/6803242</a>><br>
- eImageInfo_CorrectedSynthesize = (1 << 4),<br>
+ eImageInfo_CorrectedSynthesize = (1 << 4), // no longer set by clang<br>
eImageInfo_ImageIsSimulated = (1 << 5)<br>
};<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>