<div dir="ltr">Please back out this revert. We are far from achieving consensus on this revert being appropriate.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 9, 2014 at 11:43 AM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alp<br>
Date: Thu Jan  9 13:43:17 2014<br>
New Revision: 198885<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198885&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=198885&view=rev</a><br>
Log:<br>
Revert "Disable LeakSanitizer in TableGen binaries, see PR18325"<br>
<br>
To declare or define reserved identifers is undefined behaviour in standard<br>
C++. This needs to be addressed in compiler-rt before it can be used in LLVM.<br>
<br>
See the list discussion for details.<br>
<br>
This reverts commit r198858.<br>
<br>
Modified:<br>
    cfe/trunk/utils/TableGen/TableGen.cpp<br>
<br>
Modified: cfe/trunk/utils/TableGen/TableGen.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/TableGen.cpp?rev=198885&r1=198884&r2=198885&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/TableGen.cpp?rev=198885&r1=198884&r2=198885&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/utils/TableGen/TableGen.cpp (original)<br>
+++ cfe/trunk/utils/TableGen/TableGen.cpp Thu Jan  9 13:43:17 2014<br>
@@ -263,10 +263,3 @@ int main(int argc, char **argv) {<br>
<br>
   return TableGenMain(argv[0], &ClangTableGenMain);<br>
 }<br>
-<br>
-extern "C" {<br>
-// Disable LeakSanitizer for this binary as it has too many leaks that are not<br>
-// very interesting to fix. __lsan_is_turned_off is explained in<br>
-// compiler-rt/include/sanitizer/lsan_interface.h<br>
-int __lsan_is_turned_off() { return 1; }<br>
-}  // extern "C"<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>