<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 9, 2014 at 3:18 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 09/01/2014 11:14, Kostya Serebryany wrote:<div><div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<br>
On Thu, Jan 9, 2014 at 3:02 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
<br>
On 09/01/2014 09:26, Kostya Serebryany wrote:<br>
<br>
Author: kcc<br>
Date: Thu Jan 9 03:26:26 2014<br>
New Revision: 198858<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198858&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=198858&view=rev</a><br>
Log:<br>
Disable LeakSanitizer in TableGen binaries, see PR18325<br>
<br>
Modified:<br>
cfe/trunk/utils/TableGen/<u></u>TableGen.cpp<br>
<br>
Modified: cfe/trunk/utils/TableGen/<u></u>TableGen.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/TableGen.cpp?rev=198858&r1=198857&r2=198858&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/utils/<u></u>TableGen/TableGen.cpp?rev=<u></u>198858&r1=198857&r2=198858&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/utils/TableGen/<u></u>TableGen.cpp (original)<br>
+++ cfe/trunk/utils/TableGen/<u></u>TableGen.cpp Thu Jan 9 03:26:26 2014<br>
@@ -255,3 +255,10 @@ int main(int argc, char **argv) {<br>
return TableGenMain(argv[0], &ClangTableGenMain);<br>
}<br>
+<br>
+extern "C" {<br>
+// Disable LeakSanitizer for this binary as it has too many<br>
leaks that are not<br>
+// very interesting to fix. __lsan_is_turned_off is explained in<br>
+// compiler-rt/include/sanitizer/<u></u>lsan_interface.h<br>
+int __lsan_is_turned_off() { return 1; }<br>
+} // extern "C"<br>
<br>
<br>
Hi Kostya,<br>
<br>
This doesn't look correct and fires warnings my my strict checks<br>
build.<br>
<br>
Double-underscore prefixed identifiers are strictly reserved for<br>
the implementation.<br>
<br>
<br>
all asan/msan/lsan/tsan interface functions have __ prefix exactly because this prefix is reserved for implementation,<br>
so this is clearly what I intended to write.<br>
</blockquote>
<br></div></div>
Kostya,<br>
<br>
The sanitizers are part of the implementation and should feel free to introduce double-underscore prefixed names.<br>
<br>
This review is for a change to TableGen -- which clearly isn't part of the implementation.<br>
<br>
It is not at liberty to introduce new reserved names.<br></blockquote><div><br></div><div>What would be your suggestion (other than reverting the patch)?</div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Alp.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
Another question is how to silence your checker: please give us more info on what that is.<br>
<br>
--kcc<br>
<br>
<br>
Alp.<br>
<br>
<br>
<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br></div>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><div class="im"><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br>
-- <a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
<br>
</div></blockquote><div class="HOEnZb"><div class="h5">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div></div>