Hi Alp,<div><br></div><div>I am working on RTTI support, a prerequisite for proper EH.</div><div><br></div><div>I'm not sure why we would want to move it from MicrosoftExt.  The way I see it, we have MicrosoftMode for conforming extensions (__uuidof, etc.) and MicrosoftExt for non-conforming extensions (extra qualification on member functions, etc.).  This seems like a non-conforming extension to me.</div>
<div><br>On Saturday, January 4, 2014, Alp Toker  wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is also a good starting point if anyone wants to work on MS exception support.<br>

<br>
However while making this change it occurred to me that this should be moved from MicrosoftExt to MicrosoftMode -- thoughts?<br>
<br>
Alp.<br>
<br>
<br>
While making this change<br>
On 04/01/2014 15:25, Alp Toker wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: alp<br>
Date: Sat Jan  4 09:25:02 2014<br>
New Revision: 198497<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198497&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=198497&view=rev</a><br>
Log:<br>
Move MS predefined type_info out of InitializePredefinedMacros<br>
<br>
Instead of keeping it in amongst the macros, build the declaration at Sema init<br>
the same way we do with other predeclared and builtin types.<br>
<br>
In practice this means the declaration is marked implicit and therefore won't<br>
show up as an unwanted user-declared type in tooling which has been a<br>
frequently reported issue (though I haven't been able to cook up a test).<br>
<br>
Modified:<br>
     cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp<br>
     cfe/trunk/lib/Sema/Sema.cpp<br>
<br>
Modified: cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/InitPreprocessor.cpp?rev=198497&r1=198496&r2=198497&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/<u></u>Frontend/InitPreprocessor.cpp?<u></u>rev=198497&r1=198496&r2=<u></u>198497&view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp (original)<br>
+++ cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp Sat Jan  4 09:25:02 2014<br>
@@ -518,7 +518,6 @@ static void InitializePredefinedMacros(c<br>
      if (LangOpts.CPlusPlus) {<br>
        // FIXME: Support Microsoft's __identifier extension in the lexer.<br>
        Builder.append("#define __identifier(x) x");<br>
-      Builder.append("class type_info;");<br>
      }<br>
    }<br>
  <br>
Modified: cfe/trunk/lib/Sema/Sema.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.cpp?rev=198497&r1=198496&r2=198497&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/Sema/<u></u>Sema.cpp?rev=198497&r1=198496&<u></u>r2=198497&view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Sema/Sema.cpp (original)<br>
+++ cfe/trunk/lib/Sema/Sema.cpp Sat Jan  4 09:25:02 2014<br>
@@ -178,6 +178,13 @@ void Sema::Initialize() {<br>
        PushOnScopeChains(Context.<u></u>getObjCProtocolDecl(), TUScope);<br>
    }<br>
  +  // Initialize Microsoft "predefined C++ types".<br>
+  if (PP.getLangOpts().MicrosoftExt && PP.getLangOpts().CPlusPlus) {<br>
+    if (IdResolver.begin(&Context.<u></u>Idents.get("type_info")) == IdResolver.end())<br>
+      PushOnScopeChains(Context.<u></u>buildImplicitRecord("type_<u></u>info", TTK_Class),<br>
+                        TUScope);<br>
+  }<br>
+<br>
    // Initialize predefined OpenCL types.<br>
    if (PP.getLangOpts().OpenCL) {<br>
      addImplicitTypedef("image1d_t"<u></u>, Context.OCLImage1dTy);<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a>cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote>
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a>cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote></div>