<div dir="ltr">It seems that I mixed up <span style="font-family:arial,sans-serif;font-size:13px">MicrosoftMode and </span><span style="font-family:arial,sans-serif;font-size:13px">MicrosoftExt which lead to a discussion between Alp Toker, Aaron Ballman, and myself.</span><div>
<span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">We agreed that the current state of affairs is confusing and should be remedied:</span></div>
<div>- MicrosoftExt will be renamed to MSVCExt (and will still be controlled by -fms-extensions)</div><div>- MicrosoftMode will be renamed to MSVCCompat (and will still be controlled by -fms-compatibility)</div><div><br></div>
<div>This makes it more clear what should happen with 'struct type_info', it is a non-conforming extension and should be controlled by MSVCCompat.</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Jan 4, 2014 at 11:41 AM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
On 04/01/2014 19:09, David Majnemer wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Alp,<br>
<br>
I am working on RTTI support, a prerequisite for proper EH.<br>
<br>
I'm not sure why we would want to move it from MicrosoftExt. The way I see it, we have MicrosoftMode for conforming extensions (__uuidof, etc.) and MicrosoftExt for non-conforming extensions (extra qualification on member functions, etc.). This seems like a non-conforming extension to me.<br>
</blockquote>
<br></div>
Thanks for the clarification David.<br>
<br>
If it's the way you describe, that indicates a naming problem -- in all the other clang language standards 'Ext' and 'Mode' have opposite semantics.<br>
<br>
For example, C++11 mode is the native setting, whereas C++11 extensions is the default setting plus C++11 language features as extensions with backward compatibility.<br>
<br>
Extensions enable features without changing the core semantics, whereas a "mode" is potentially a whole different incompatible/vendor-specific language dialect.<br>
<br>
In contrast, it appears that MicrosoftExt has become the native/MSVC mode whereas MicrosoftMode is now being used as a flag to add Microsoft extensions usable in conforming code.<br>
<br>
A quick grep shows they're used interchangeably, depending on who wrote the code.<br>
<br>
In practice it looks like comments and variable names already refer to MicrosoftExt as "Microsoft mode"...<br>
<br>
lib/Basic/Builtins.cpp: MSModeUnsupported = !LangOpts.MicrosoftExt<br>
<br>
... and refer to MicrosoftMode as "Microsoft extensions" ...<br>
<br>
lib/Sema/SemaDecl.cpp: if (getLangOpts().MicrosoftMode)<br>
lib/Sema/SemaDecl.cpp- DiagID = diag::ext_ms_forward_ref_enum;<br>
<br>
Did we just discover a case of unchecked confusion? :-)<span class="HOEnZb"><font color="#888888"><br>
<br>
Alp.</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Saturday, January 4, 2014, Alp Toker wrote:<br>
<br>
This is also a good starting point if anyone wants to work on MS<br>
exception support.<br>
<br>
However while making this change it occurred to me that this<br>
should be moved from MicrosoftExt to MicrosoftMode -- thoughts?<br>
<br>
Alp.<br>
<br>
<br>
While making this change<br>
On 04/01/2014 15:25, Alp Toker wrote:<br>
<br>
Author: alp<br>
Date: Sat Jan 4 09:25:02 2014<br>
New Revision: 198497<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198497&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=198497&view=rev</a><br>
Log:<br>
Move MS predefined type_info out of InitializePredefinedMacros<br>
<br>
Instead of keeping it in amongst the macros, build the<br>
declaration at Sema init<br>
the same way we do with other predeclared and builtin types.<br>
<br>
In practice this means the declaration is marked implicit and<br>
therefore won't<br>
show up as an unwanted user-declared type in tooling which has<br>
been a<br>
frequently reported issue (though I haven't been able to cook<br>
up a test).<br>
<br>
Modified:<br>
cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp<br>
cfe/trunk/lib/Sema/Sema.cpp<br>
<br>
Modified: cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/InitPreprocessor.cpp?rev=198497&r1=198496&r2=198497&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/<u></u>Frontend/InitPreprocessor.cpp?<u></u>rev=198497&r1=198496&r2=<u></u>198497&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp (original)<br>
+++ cfe/trunk/lib/Frontend/<u></u>InitPreprocessor.cpp Sat Jan 4<br>
09:25:02 2014<br>
@@ -518,7 +518,6 @@ static void InitializePredefinedMacros(c<br>
if (LangOpts.CPlusPlus) {<br>
// FIXME: Support Microsoft's __identifier extension<br>
in the lexer.<br>
Builder.append("#define __identifier(x) x");<br>
- Builder.append("class type_info;");<br>
}<br>
}<br>
<br>
Modified: cfe/trunk/lib/Sema/Sema.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.cpp?rev=198497&r1=198496&r2=198497&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/Sema/<u></u>Sema.cpp?rev=198497&r1=198496&<u></u>r2=198497&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/Sema/Sema.cpp (original)<br>
+++ cfe/trunk/lib/Sema/Sema.cpp Sat Jan 4 09:25:02 2014<br>
@@ -178,6 +178,13 @@ void Sema::Initialize() {<br>
PushOnScopeChains(Context.<u></u>getObjCProtocolDecl(), TUScope);<br>
}<br>
+ // Initialize Microsoft "predefined C++ types".<br>
+ if (PP.getLangOpts().MicrosoftExt &&<br>
PP.getLangOpts().CPlusPlus) {<br>
+ if (IdResolver.begin(&Context.<u></u>Idents.get("type_info")) ==<br>
IdResolver.end())<br>
+ PushOnScopeChains(Context.<u></u>buildImplicitRecord("type_<u></u>info",<br>
TTK_Class),<br>
+ TUScope);<br>
+ }<br>
+<br>
// Initialize predefined OpenCL types.<br>
if (PP.getLangOpts().OpenCL) {<br>
addImplicitTypedef("image1d_t"<u></u>, Context.OCLImage1dTy);<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br>
-- <a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote>
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div>