<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Dec 30, 2013 at 6:09 AM, Kim Gräsman <span dir="ltr"><<a href="mailto:kim.grasman@gmail.com" target="_blank">kim.grasman@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Mon, Dec 30, 2013 at 7:18 AM, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br>

> Author: chapuni<br>
> Date: Mon Dec 30 00:18:08 2013<br>
> New Revision: 198204<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198204&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=198204&view=rev</a><br>
> Log:<br>
> Make lit.site.cfg Py3-compatible. Copied from r188041.<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/test/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a><br>
><br>
> Modified: clang-tools-extra/trunk/test/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/lit.site.cfg.in?rev=198204&r1=198203&r2=198204&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/lit.site.cfg.in?rev=198204&r1=198203&r2=198204&view=diff</a><br>

> ==============================================================================<br>
> --- clang-tools-extra/trunk/test/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a> (original)<br>
> +++ clang-tools-extra/trunk/test/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a> Mon Dec 30 00:18:08 2013<br>
> @@ -1,3 +1,5 @@<br>
> +import sys<br>
> +<br>
>  ## Autogenerated by LLVM/Clang configuration.<br>
>  # Do not edit!<br>
>  config.llvm_src_root = "@LLVM_SOURCE_DIR@"<br>
> @@ -14,7 +16,8 @@ config.have_libedit = "@HAVE_LIBEDIT@"<br>
>  try:<br>
>      config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params<br>
>      config.llvm_libs_dir = config.llvm_libs_dir % lit_config.params<br>
> -except KeyError,e:<br>
> +except KeyError:<br>
> +    e = sys.exc_info()[1]<br>
<br>
</div></div>What's the range of supported Python versions? Python 2.6 and later<br>
supports 'as' instead of ',':<br>
<br>
  try:<br>
    ...<br>
  except KeyError as e:<br>
    ...<br>
<br>
It's cleaner than unpacking exception info from sys.exc_info.<br></blockquote><div><br></div><div>alp landed a change containing the "as" keyword and it broke a few of the buildbots. So it sounds at least some of the bots use a Python older than 2.6 at the moment.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
FWIW,<br>
- Kim<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>