Can you make sure to explain why it's dead in the commit messages (for now a followup to the commit would be nice).<br><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div><br><div>On Mon Dec 23 2013 at 11:17:10 AM, Adrian Prantl <<a href="mailto:aprantl@apple.com">aprantl@apple.com</a>> wrote:</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Mon Dec 23 13:10:57 2013<br>
New Revision: 197916<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197916&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=197916&view=rev</a><br>
Log:<br>
remove dead code.<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/<u></u>CGDebugInfo.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/<u></u>CGDebugInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=197916&r1=197915&r2=197916&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/CodeGen/<u></u>CGDebugInfo.cpp?rev=197916&r1=<u></u>197915&r2=197916&view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/CodeGen/<u></u>CGDebugInfo.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/<u></u>CGDebugInfo.cpp Mon Dec 23 13:10:57 2013<br>
@@ -1470,7 +1470,7 @@ llvm::DIType CGDebugInfo::CreateType(con<br>
        !RD-><u></u>isCompleteDefinitionRequired() && CGM.getLangOpts().CPlusPlus) ||<br>
       // If the class is dynamic, only emit a declaration. A definition will be<br>
       // emitted whenever the vtable is emitted.<br>
-      (CXXDecl && CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()) || T) {<br>
+      (CXXDecl && CXXDecl->hasDefinition() && CXXDecl->isDynamicClass())) {<br>
     llvm::DIDescriptor FDContext =<br>
       getContextDescriptor(cast<<u></u>Decl>(RD->getDeclContext()));<br>
     if (!T)<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote>