<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 18/12/2013 06:55, Daniel Jasper
wrote:<br>
</div>
<blockquote
cite="mid:CAK_tg0wB2K29WO3WEnB8b0eObFdmnLkhSXgb8UgYrmjzDp7kAQ@mail.gmail.com"
type="cite">
<div dir="ltr">I think we should revert this. cl is also the
default extension for common lisp programs and we most
definitely don't format those correctly (or within reasonable
amount of time).</div>
</blockquote>
<br>
I found 60 OpenCL files and 2 lisp files in the nearest source tree
I had to hand.<br>
<br>
And of those two, both list files have the .el extension, not .cl.<br>
<br>
A lisp developer* says on the topic:<br>
<br>
<blockquote type="cite">
<meta charset="utf-8">
<p style="margin: 0px 0px 1em; padding: 0px; border: 0px;
font-size: 14px; vertical-align: baseline; background-color:
rgb(255, 255, 255); clear: both; color: rgb(0, 0, 0);
font-family: Arial, 'Liberation Sans', 'DejaVu Sans',
sans-serif; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: 18px;
orphans: auto; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-position: initial initial; background-repeat: initial
initial;">Common Lisp pathname endings for source code:</p>
<ul style="margin: 0px 0px 1em 30px; padding: 0px; border: 0px;
font-size: 14px; vertical-align: baseline; background-color:
rgb(255, 255, 255); list-style: disc; color: rgb(0, 0, 0);
font-family: Arial, 'Liberation Sans', 'DejaVu Sans',
sans-serif; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: 18px;
orphans: auto; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-position: initial initial; background-repeat: initial
initial;">
<li style="margin: 0px; padding: 0px; border: 0px; font-size:
14px; vertical-align: baseline; background-color: transparent;
background-position: initial initial; background-repeat:
initial initial;"><code style="margin: 0px; padding: 0px;
border: 0px; font-size: 14px; vertical-align: baseline;
background-color: rgb(238, 238, 238); font-family: Consolas,
Menlo, Monaco, 'Lucida Console', 'Liberation Mono', 'DejaVu
Sans Mono', 'Bitstream Vera Sans Mono', 'Courier New',
monospace, serif; background-position: initial initial;
background-repeat: initial initial;">lisp</code><span
class="Apple-converted-space"> </span>is the default. Use
this if possible.</li>
<li style="margin: 0px; padding: 0px; border: 0px; font-size:
14px; vertical-align: baseline; background-color: transparent;
background-position: initial initial; background-repeat:
initial initial;"><code style="margin: 0px; padding: 0px;
border: 0px; font-size: 14px; vertical-align: baseline;
background-color: rgb(238, 238, 238); font-family: Consolas,
Menlo, Monaco, 'Lucida Console', 'Liberation Mono', 'DejaVu
Sans Mono', 'Bitstream Vera Sans Mono', 'Courier New',
monospace, serif; background-position: initial initial;
background-repeat: initial initial;">lsp</code><span
class="Apple-converted-space"> </span>if the pathname type
allows only three characters</li>
<li style="margin: 0px; padding: 0px; border: 0px; font-size:
14px; vertical-align: baseline; background-color: transparent;
background-position: initial initial; background-repeat:
initial initial;"><code style="margin: 0px; padding: 0px;
border: 0px; font-size: 14px; vertical-align: baseline;
background-color: rgb(238, 238, 238); font-family: Consolas,
Menlo, Monaco, 'Lucida Console', 'Liberation Mono', 'DejaVu
Sans Mono', 'Bitstream Vera Sans Mono', 'Courier New',
monospace, serif; background-position: initial initial;
background-repeat: initial initial;">l</code><span
class="Apple-converted-space"> </span>if the pathname type
should be one character (rare).</li>
</ul>
<p style="margin: 0px 0px 1em; padding: 0px; border: 0px;
font-size: 14px; vertical-align: baseline; background-color:
rgb(255, 255, 255); clear: both; color: rgb(0, 0, 0);
font-family: Arial, 'Liberation Sans', 'DejaVu Sans',
sans-serif; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height: 18px;
orphans: auto; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-position: initial initial; background-repeat: initial
initial;">The pathname type<span class="Apple-converted-space"> </span><code
style="margin: 0px; padding: 1px 5px; border: 0px; font-size:
14px; vertical-align: baseline; background-color: rgb(238,
238, 238); font-family: Consolas, Menlo, Monaco, 'Lucida
Console', 'Liberation Mono', 'DejaVu Sans Mono', 'Bitstream
Vera Sans Mono', 'Courier New', monospace, serif;
background-position: initial initial; background-repeat:
initial initial;">cl</code><span class="Apple-converted-space"> </span>is
mostly not used. You can see it sometimes in older code or
projects which use several different Lisp dialects.</p>
</blockquote>
<br>
The odds of someone running the clang-format-diff.py tool on such a
file seems remote.<br>
<br>
Meanwhile there's an immediate benefit to formatting source files we
know about and have to maintain here on the project.<br>
<br>
If someone insists on running a C-family formatting tool on their
lisp files, they could simply exclude them with the -regex option we
added recently..<br>
<br>
On the other hand, I found more than 100 .m files on my drive that
were MATLAB files. If this is a genuine concern I suggest we start
there ;-)<br>
<br>
Alp.<br>
<br>
*
<a class="moz-txt-link-freetext" href="http://stackoverflow.com/questions/15187240/what-is-the-convention-for-lisp-filename-extension">http://stackoverflow.com/questions/15187240/what-is-the-convention-for-lisp-filename-extension</a><br>
<br>
<br>
<br>
<blockquote
cite="mid:CAK_tg0wB2K29WO3WEnB8b0eObFdmnLkhSXgb8UgYrmjzDp7kAQ@mail.gmail.com"
type="cite">
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">On Wed, Dec 18, 2013 at 1:58 AM, Alp
Toker <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: alp<br>
Date: Tue Dec 17 18:58:58 2013<br>
New Revision: 197542<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=197542&view=rev"
target="_blank">http://llvm.org/viewvc/llvm-project?rev=197542&view=rev</a><br>
Log:<br>
clang-format-diff.py: add the OpenCL file extension<br>
<br>
It's handled correctly as a C-family language.<br>
<br>
Modified:<br>
cfe/trunk/tools/clang-format/clang-format-diff.py<br>
<br>
Modified: cfe/trunk/tools/clang-format/clang-format-diff.py<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-format/clang-format-diff.py?rev=197542&r1=197541&r2=197542&view=diff"
target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-format/clang-format-diff.py?rev=197542&r1=197541&r2=197542&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/clang-format/clang-format-diff.py
(original)<br>
+++ cfe/trunk/tools/clang-format/clang-format-diff.py Tue
Dec 17 18:58:58 2013<br>
@@ -47,7 +47,7 @@ def main():<br>
help='custom pattern selecting file
paths to reformat '<br>
'(case sensitive, override -iregex)')<br>
parser.add_argument('-iregex', metavar='PATTERN',
default=<br>
-
r'.*\.(cpp|cc|c\+\+|cxx|c|h|hpp|m|mm|inc|js)',<br>
+
r'.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hpp|m|mm|inc|js)',<br>
help='custom pattern selecting file
paths to reformat '<br>
'(case insensitive, override
-regex)')<br>
parser.add_argument(<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.nuanti.com">http://www.nuanti.com</a>
the browser experts
</pre>
</body>
</html>