<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I mean we can continue the discussion in the phabricator.<div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div style=""><div>On Dec 17, 2013, at 4:30 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">I have created a phabricator for this:<br><a href="http://llvm-reviews.chandlerc.com/D2430">http://llvm-reviews.chandlerc.com/D2430</a><br><br>We can continue the discussion here.<br><br>On Dec 17, 2013, at 4:17 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>> wrote:<br><br><blockquote type="cite">On Tue, Dec 17, 2013 at 4:15 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:<br><blockquote type="cite">Hi Hal,<br><br>Thanks for you feedbacks.<br><br>On Dec 17, 2013, at 3:53 PM, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:<br><br>Hi Quentin,<br><br>Any reason you did not use phabricator for this patch?<br><br>I thought it was trivial enough not to require a phabricator.<br><br><br>+def BackendInlineAsm : DiagGroup<"backend-inline-asm">;<br><br>+def BackendStackSize : DiagGroup<"backend-stack-size">;<br><br>+def BackendPlugin : DiagGroup<"backend-plugin">;<br><br>Are these group names user-visible?<br><br>I think they are. At least, I get this name when a warning is issued:<br>warning: stack size exceeded (168) in main [-Wbackend-stack-size]<br>1 warning generated.<br><br>If they are, do we want "backend" in the name?<br><br>I do not have any strong opinion on that.<br>This prefix makes it clear that these diagnostics are issued by the backend.<br>I thought it may be useful to have a naming convention for those.<br></blockquote><br>At least for built-in diagnostics, inline-asm and stack-size, users<br>don't really care which part of the compiler produces the diagnostic.<br>Also, which flag does GCC use for these? We should be compatible if<br>possible.<br></blockquote>The stack size more or less matches this warning in GCC:<br>-Wframe-larger-than=<limit><br>Though we do not have a way to reproduce that behavior in clang at the moment, see the Missing Points.<br>For inline asm, I do not know what GCC has.<br><br>-Quentin<br><br><br><blockquote type="cite"><br>Dmitri<br><br>--<span class="Apple-converted-space"> </span><br>main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/</blockquote></div></blockquote></div><br></div></body></html>