<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 13, 2013 at 11:33 AM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On 13/12/2013 18:23, Richard Smith wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
case EXPR_BINARY_TYPE_TRAIT:<br>
- S = new (Context) BinaryTypeTraitExpr(Empty);<br>
+ llvm_unreachable("obsolete");<br>
break;<br>
<br>
Please just remove this, and EXPR_BINARY_TYPE_TRAIT.<br>
</blockquote>
<br></div>
Great, if there is no need to maintain the serialization I'll get rid of that too.<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
I don't really like having BTT_* and TT_* in the same enum, with default: clauses appearing in various switches. Are you planning on folding the trait-handling code together more (and dropping the 'B')? If so, looks fine as a step towards that.<br>
</blockquote>
<br></div>
Indeed, the BTT/TT prefix and remaining differences will melt away in smaller upcoming tidy-ups which I'll land directly.<br></blockquote><div><br></div><div>Great, thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Are we good to go with the initial MSVC 2013 traits as well?<br></blockquote><div><br></div><div>I need some more time to review that patch; please hold off on that one for now, and I'll get back to you on it as soon as I can (hopefully on Monday).</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for reviewing!<br>
<br>
Alp.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
<br>
On Fri, Dec 13, 2013 at 6:58 AM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
Forgot to mention, this is built on top of the MSVC 2013 type<br>
trait support patch which has yet to land. Delta should be small<br>
though.<br>
<br>
Alp.<br>
<br>
<br>
On 13/12/2013 14:56, Alp Toker wrote:<br>
<br>
There's nothing special about type traits accepting two arguments.<br>
<br>
The attached patch eliminates BinaryTypeTraitExpr and switches<br>
all related handling over to TypeTraitExpr.<br>
<br>
Also fixes a CodeGen failure with variadic type traits<br>
appearing in a non-constant expression.<br>
<br>
The BTT/TT prefix distinction is retained for the time being.<br>
<br>
This is part of the ongoing work to unify type traits.<br>
<br>
26 files changed, 62 insertions(+), 289 deletions(-)<br>
<br>
Alp.<br>
<br>
<br>
-- <a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br></div>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br>
</blockquote><div class="HOEnZb"><div class="h5">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div></div>