<div dir="ltr">Looks great, thanks!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 11, 2013 at 10:39 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Type trait parsing is all over the place at the moment with unary, binary and n-ary C++11 type traits having been developed independently through different points in clang's history.<br>
<br>
There's no good reason to handle them separately -- there are three parsers, three AST nodes and lots of duplicated handling code with slightly different implementations and diags for each kind.<br>
<br>
The attached patch unifies parsing of type traits and sets the stage for further consolidation.<br>
<br>
No change in behaviour other than slightly more consistent error recovery.<br>
<br>
9 files changed, 141 insertions(+), 330 deletions(-)<span class="HOEnZb"><font color="#888888"><br>
<br>
Alp.<br>
<br>
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</font></span><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>