<div dir="ltr">Reverted in r197192, getting this dependent on being able to mangle anonymous entities in general.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 12, 2013 at 3:56 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Using the mangled name of the variable for its lifetime-extended temporaries doesn't sound right to me. Given:<div>
<br></div><div><div> int n; </div><div> int &&r = +n;</div></div><div><br></div>
<div>Clang generates:</div><div><br></div><div><div> @"\01?r@@3$$QEAHEA" = global i32* null, align 8</div><div> @"\01?r@@3$$QEAHEA1" = private global i32 0, align 4</div></div><div><br></div><div>... where the latter is the lifetime-extended temporary, with a suspicious mangling.</div>
<div><br></div><div><br></div><div>Given:</div><div><br></div><div> int &&r = 0;<br></div><div><br></div><div>Clang asserts:</div><div><br></div><div> Global variable initializer type does not match global variable type!</div>
<div><div> i32** @"\01?r@@3$$QEAHEA"</div><div> Broken module found, compilation aborted!</div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 12, 2013 at 3:12 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Thu Dec 12 17:12:01 2013<br>
New Revision: 197184<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197184&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=197184&view=rev</a><br>
Log:<br>
[-cxx-abi microsoft] Mangle reference temporaries<br>
<br>
They are mangled the same as normal references, nothing special is going<br>
on here.<br>
<br>
Modified:<br>
cfe/trunk/lib/AST/MicrosoftMangle.cpp<br>
cfe/trunk/test/CodeGenCXX/mangle-ms.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=197184&r1=197183&r2=197184&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=197184&r1=197183&r2=197184&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/AST/MicrosoftMangle.cpp (original)<br>
+++ cfe/trunk/lib/AST/MicrosoftMangle.cpp Thu Dec 12 17:12:01 2013<br>
@@ -2040,10 +2040,9 @@ void MicrosoftMangleContextImpl::mangleC<br>
}<br>
<br>
void MicrosoftMangleContextImpl::mangleReferenceTemporary(const VarDecl *VD,<br>
- raw_ostream &) {<br>
- unsigned DiagID = getDiags().getCustomDiagID(DiagnosticsEngine::Error,<br>
- "cannot mangle this reference temporary yet");<br>
- getDiags().Report(VD->getLocation(), DiagID);<br>
+ raw_ostream &Out) {<br>
+ MicrosoftCXXNameMangler mangler(*this, Out);<br>
+ mangler.mangle(VD);<br>
}<br>
<br>
void MicrosoftMangleContextImpl::mangleStaticGuardVariable(const VarDecl *VD,<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/mangle-ms.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-ms.cpp?rev=197184&r1=197183&r2=197184&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-ms.cpp?rev=197184&r1=197183&r2=197184&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/mangle-ms.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/mangle-ms.cpp Thu Dec 12 17:12:01 2013<br>
@@ -445,3 +445,10 @@ decltype(a) fun(decltype(a) x, decltype(<br>
// CHECK-DAG: ?fun@PR18022@@YA?AU<unnamed-type-a>@1@U21@0@Z<br>
<br>
}<br>
+<br>
+// Binding to a bit-field that requires a temporary.<br>
+struct { int bitfield : 3; } object_with_bitfield = { 3 };<br>
+const int &reference_to_bitfield = object_with_bitfield.bitfield;<br>
+// CHECK-DAG: ?object_with_bitfield@@3U<unnamed-type-object_with_bitfield>@@A<br>
+// CHECK-DAG: ?reference_to_bitfield@@3ABHB<br>
+// CHECK-DAG: ??__Ereference_to_bitfield@@YAXXZ<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>