<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 12/12/2013 04:53, Hans Wennborg
wrote:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-gu5wzni5o23mttezx3t6-req@llvm-reviews.chandlerc.com"
type="cite">
<pre wrap="">Hi rsmith,
As suggested by Richard in <a class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D2388?id=6039#inline-12744">http://llvm-reviews.chandlerc.com/D2388?id=6039#inline-12744</a>, let's just allow regexes in all verifier directives and drop -re variants to simplify things.</pre>
</blockquote>
<br>
Hi Hans,<br>
<br>
This is a good idea, but I'd really like to see your new regex
blocks use a character other than curly braces.<br>
<br>
The problem is that {{}} for regular expressions conflicts visually
and syntactically with the outer {{}} in a way that makes it quite
difficult to see what's going on.<br>
<br>
A secondary concern is that it looks a bit like FileCheck syntax but
in fact works on a different level with different inputs and outputs
is rather confusing.<br>
<br>
So instead of:<br>
<br>
<blockquote><code>// expected-error {{message {{[^']+}}}}</code><code></code><br>
<code></code></blockquote>
<br>
How about this syntax?<br>
<br>
<blockquote><code>// expected-error {{message ~/[^']+/}}</code><br>
</blockquote>
<br>
It's instantly recognisable and has a regular grammar that enables
code editors do syntax highlighting, regex completion etc.<br>
<br>
Alp.<br>
<br>
<br>
<br>
<blockquote
cite="mid:differential-rev-PHID-DREV-gu5wzni5o23mttezx3t6-req@llvm-reviews.chandlerc.com"
type="cite">
<pre wrap="">
The only thing this doesn't simplify is the constexpr-printing.cpp test, but perhaps we can live with that.
<a class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D2392">http://llvm-reviews.chandlerc.com/D2392</a>
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Frontend/VerifyDiagnosticConsumer.h
lib/Frontend/VerifyDiagnosticConsumer.cpp
test/Analysis/analyzer-stats.c
test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p1.cpp
test/CXX/drs/dr14xx.cpp
test/CXX/special/class.copy/implicit-move.cpp
test/Lexer/hexfloat.cpp
test/Misc/verify.c
test/Parser/attributes.mm
test/Sema/format-strings-scanf.c
test/Sema/ms-wchar.c
test/Sema/thread-specifier.c
test/SemaCXX/addr-of-overloaded-function.cpp
test/SemaCXX/constexpr-printing.cpp
test/SemaCXX/member-expr.cpp
test/SemaCXX/nested-name-spec.cpp
test/SemaCXX/operator-arrow-depth.cpp
test/SemaCXX/pr13394-crash-on-invalid.cpp
test/SemaCXX/qualified-id-lookup.cpp
test/SemaCXX/typo-correction-pt2.cpp
test/SemaCXX/typo-correction.cpp
test/SemaTemplate/dependent-names.cpp
test/SemaTemplate/ms-lookup-template-base-classes.cpp
test/SemaTemplate/typename-specifier.cpp
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.nuanti.com">http://www.nuanti.com</a>
the browser experts
</pre>
</body>
</html>