<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoPlainText>Hi Reid,<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>I am not sure what you mean. I am not too familiar with the windows tool chain, but the error here looks reasonable. I see that there is actually a test that explicitly checks for that error: test/Driver/no-integrated-as-win.c<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>You can get the error by compiling for windows with '-target win32 -no-integrated-as'. My test used the -no-integrated-as flag and was failing because the default target on your build was win32, so I explicitly set the target in the test.<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>Is there something more to fix here?<o:p></o:p></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Reid Kleckner [mailto:rnk@google.com] <br><b>Sent:</b> Monday, December 09, 2013 7:39 PM<br><b>To:</b> David Peixotto<br><b>Cc:</b> cfe-commits@cs.uiuc.edu cfe<br><b>Subject:</b> Re: r196854 - Fix via-file-asm test failure on windows<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>There's still an assert here I'd like to get fixed. If you remove the target we still crash.<o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Mon, Dec 9, 2013 at 4:54 PM, David Peixotto <<a href="mailto:dpeixott@codeaurora.org" target="_blank">dpeixott@codeaurora.org</a>> wrote:<o:p></o:p></p><p class=MsoNormal>Author: dpeixott<br>Date: Mon Dec 9 18:54:30 2013<br>New Revision: 196854<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=196854&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=196854&view=rev</a><br>Log:<br>Fix via-file-asm test failure on windows<br><br>The windows target does not support using an external assembler so<br>the test case was failing with this error:<br><br>error: there is no external assembler that can be used on this platform<br><br>The test was updated to always explicitly pass a target that has<br>both an interal and external assembler.<br><br>Modified:<br> cfe/trunk/test/Driver/via-file-asm.c<br><br>Modified: cfe/trunk/test/Driver/via-file-asm.c<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?rev=196854&r1=196853&r2=196854&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?rev=196854&r1=196853&r2=196854&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/Driver/via-file-asm.c (original)<br>+++ cfe/trunk/test/Driver/via-file-asm.c Mon Dec 9 18:54:30 2013<br>@@ -1,14 +1,10 @@<br> // Should save and read back the assembly from a file<br>-// RUN: %clang -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s<br>+// RUN: %clang -target arm-none-linux-gnueabi -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s<br> // CHECK: "-cc1"<br> // CHECK: "-o" "[[TMP:[^"]*]]"<br> // CHECK: -cc1as<br> // CHECK: [[TMP]]<br><br> // Should not force using the integrated assembler<br>-// RUN: %clang -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s<br>+// RUN: %clang -target arm-none-linux-gnueabi -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s<br> // NO_IAS-NOT: "-cc1as"<br>-<br>-// Test arm target specifically for the same behavior<br>-// RUN: %clang -target arm -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s<br>-// RUN: %clang -target arm -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p></div></div></div></body></html>