<div dir="ltr">No, I can't reproduce the problem. I was getting an assertion failure from this command after the diagnostic, but now it exits zero:<div><br><div><div>$ ./bin/clang.exe -no-integrated-as -via-file-asm t.cpp -c --target=i686-pc-win32 -### ; echo $?</div>
</div><div><div>clang version 3.5</div><div>Target: i686-pc-win32</div><div>Thread model: posix</div><div>clang.exe: error: there is no external assembler that can be used on this platform</div><div>0</div></div><div><br>
</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 10, 2013 at 10:30 AM, David Peixotto <span dir="ltr"><<a href="mailto:dpeixott@codeaurora.org" target="_blank">dpeixott@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p>Hi Reid,<u></u><u></u></p><p><u></u> <u></u></p><p>I am not sure what you mean. I am not too familiar with the windows tool chain, but the error here looks reasonable. I see that there is actually a test that explicitly checks for that error: test/Driver/no-integrated-as-win.c<u></u><u></u></p>
<p><u></u> <u></u></p><p>You can get the error by compiling for windows with '-target win32 -no-integrated-as'. My test used the -no-integrated-as flag and was failing because the default target on your build was win32, so I explicitly set the target in the test.<u></u><u></u></p>
<p><u></u> <u></u></p><p>Is there something more to fix here?<u></u><u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Reid Kleckner [mailto:<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>] <br>
<b>Sent:</b> Monday, December 09, 2013 7:39 PM<br><b>To:</b> David Peixotto<br><b>Cc:</b> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> cfe<br><b>Subject:</b> Re: r196854 - Fix via-file-asm test failure on windows<u></u><u></u></span></p>
</div></div><div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">There's still an assert here I'd like to get fixed. If you remove the target we still crash.<u></u><u></u></p></div>
<div><p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p><div><p class="MsoNormal">On Mon, Dec 9, 2013 at 4:54 PM, David Peixotto <<a href="mailto:dpeixott@codeaurora.org" target="_blank">dpeixott@codeaurora.org</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: dpeixott<br>Date: Mon Dec 9 18:54:30 2013<br>New Revision: 196854<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=196854&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=196854&view=rev</a><br>
Log:<br>Fix via-file-asm test failure on windows<br><br>The windows target does not support using an external assembler so<br>the test case was failing with this error:<br><br>error: there is no external assembler that can be used on this platform<br>
<br>The test was updated to always explicitly pass a target that has<br>both an interal and external assembler.<br><br>Modified:<br> cfe/trunk/test/Driver/via-file-asm.c<br><br>Modified: cfe/trunk/test/Driver/via-file-asm.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?rev=196854&r1=196853&r2=196854&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?rev=196854&r1=196853&r2=196854&view=diff</a><br>
==============================================================================<br>--- cfe/trunk/test/Driver/via-file-asm.c (original)<br>+++ cfe/trunk/test/Driver/via-file-asm.c Mon Dec 9 18:54:30 2013<br>@@ -1,14 +1,10 @@<br>
// Should save and read back the assembly from a file<br>-// RUN: %clang -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s<br>+// RUN: %clang -target arm-none-linux-gnueabi -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s<br>
// CHECK: "-cc1"<br> // CHECK: "-o" "[[TMP:[^"]*]]"<br> // CHECK: -cc1as<br> // CHECK: [[TMP]]<br><br> // Should not force using the integrated assembler<br>-// RUN: %clang -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s<br>
+// RUN: %clang -target arm-none-linux-gnueabi -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s<br> // NO_IAS-NOT: "-cc1as"<br>-<br>-// Test arm target specifically for the same behavior<br>
-// RUN: %clang -target arm -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s<br>-// RUN: %clang -target arm -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s<br><br><br>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</div><p class="MsoNormal"><u></u> <u></u></p></div></div></div></div></div></div></blockquote></div><br></div>