<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Dec 10, 2013, at 5:41 , Anders Rönnholm <<a href="mailto:Anders.Ronnholm@evidente.se">Anders.Ronnholm@evidente.se</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="SV" link="blue" vlink="purple" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="WordSection1" style="page: WordSection1;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">Thanks for the comments. New iteration with the comments addressed.<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);"> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">+ + static PathDiagnosticLocation createConditionalColonLoc(<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">+ + const ConditionalOperator *CO,<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">+ + const SourceManager &SM);<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);"> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">+ + I think the new style is to either break after the return type or to double-indent wrapped arguments, rather than right-aligning + them. (Right-aligning is harder to maintain.)<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US"> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 13px; font-family: 'Times New Roman', serif;"><span lang="EN-US" style="font-size: 12px; font-family: Calibri, sans-serif; color: rgb(31, 73, 125);">I'd like to keep this as it is since there are other create functions next to it that uses this style, this also applies to the ccp file. We could make a separate patch later and change them all to the new style. I believe the coding standard also states that we should use the same style already used in the source.<o:p></o:p></span></div></div></div></blockquote><br></div><div>Fair enough. Committed in r196937!</div><div><br></div><div>I also did some minor cleanups in r196938. Can you check that these look correct?</div><div><br></div><div>Jordan</div></body></html>