<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Thanks, this is better. Still have some comments though.</div><br><div><div>On Dec 9, 2013, at 14:04 , Fariborz Jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">+ def err_objc_bridged_related_unknown_method : Error<</span><br style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">+ "you can't convert %0 to %1, without using an existing "</span><br style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">+ "%select{class|instance}2 method for this conversion">;</span><br style="font-family: Monaco; font-size: 10px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></blockquote></div><br><div>I still don't see what this diagnostic adds. If the framework doesn't have a method name for one of the conversion directions, that probably means there's no one good way to perform this conversion. There may be <i>no</i> way to perform the conversion, although it's strange that they would be marked related, then.</div><div><br></div><div>Also, diagnostics generally don't have "you" except in the fix-it bit ("did you mean...").</div><div><br></div><div>How about just "%0 cannot be directly converted to %1"?</div><div><br></div><div><br></div><div><blockquote type="cite"><span style="font-family: Monaco; font-size: 10px;"> Diag(Loc, diag::err_objc_bridged_related_unknown_method)</span><br style="font-family: Monaco; font-size: 10px;"><span style="font-family: Monaco; font-size: 10px;">- << SrcType << DestType << RelatedClass->getName() << 0;</span><br style="font-family: Monaco; font-size: 10px;"><span style="font-family: Monaco; font-size: 10px;">+ << SrcType << DestType << 0;</span><br style="font-family: Monaco; font-size: 10px;"></blockquote><br></div><div>Here and elsewhere I think it makes sense to use false/true rather than 0/1 for the select parameter. If not that, then perhaps a local enum { IsClass = 0, IsInstance };</div><div><br></div><div>Jordan</div></body></html>