<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Dec 10, 2013, at 8:04 AM, Alp Toker <<a href="mailto:alp@nuanti.com">alp@nuanti.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>On 14/11/2013 16:33, Argyrios Kyrtzidis wrote:<br><blockquote type="cite">Author: akirtzidis<br>Date: Thu Nov 14 10:33:29 2013<br>New Revision: 194710<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194710&view=rev">http://llvm.org/viewvc/llvm-project?rev=194710&view=rev</a><br>Log:<br>[objcmt] Introduce "objcmt-white-list-dir-path=" option.<br><br>This options accepts a path to a directory, collects the filenames of the files<br>it contains, and the migrator will only modify files with the same filename.<br><br>Added:<br> cfe/trunk/test/ARCMT/whitelisted/<br> cfe/trunk/test/ARCMT/whitelisted/Inputs/<br> cfe/trunk/test/ARCMT/whitelisted/Inputs/header1.h<br> cfe/trunk/test/ARCMT/whitelisted/header1.h<br> cfe/trunk/test/ARCMT/whitelisted/header1.h.result<br> cfe/trunk/test/ARCMT/whitelisted/header2.h<br> cfe/trunk/test/ARCMT/whitelisted/header2.h.result<br> cfe/trunk/test/ARCMT/whitelisted/objcmt-with-whitelist.m<br>Modified:<br> cfe/trunk/include/clang/Driver/Options.td<br> cfe/trunk/include/clang/Frontend/FrontendOptions.h<br> cfe/trunk/lib/ARCMigrate/ObjCMT.cpp<br> cfe/trunk/lib/Driver/Tools.cpp<br> cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br><br>Modified: cfe/trunk/include/clang/Driver/Options.td<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=194710&r1=194709&r2=194710&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=194710&r1=194709&r2=194710&view=diff</a><br>==============================================================================<br>--- cfe/trunk/include/clang/Driver/Options.td (original)<br>+++ cfe/trunk/include/clang/Driver/Options.td Thu Nov 14 10:33:29 2013<br>@@ -178,13 +178,14 @@ def objcmt_migrate_nsmacros : Flag<["-"]<br> HelpText<"Enable migration to NS_ENUM/NS_OPTIONS macros">;<br> def objcmt_migrate_protocol_conformance : Flag<["-"], "objcmt-migrate-protocol-conformance">, Flags<[CC1Option]>,<br> HelpText<"Enable migration to add protocol conformance on classes">;<br>-def objcmt_atomic_property : Flag<["-"], "objcmt-atomic-property">,<br>- Flags<[CC1Option]>,<br>+def objcmt_atomic_property : Flag<["-"], "objcmt-atomic-property">, Flags<[CC1Option]>,<br> HelpText<"Make migration to 'atomic' properties">;<br> def objcmt_returns_innerpointer_property : Flag<["-"], "objcmt-returns-innerpointer-property">, Flags<[CC1Option]>,<br> HelpText<"Enable migration to annotate property with NS_RETURNS_INNER_POINTER">;<br> def objcmt_ns_nonatomic_iosonly: Flag<["-"], "objcmt-ns-nonatomic-iosonly">, Flags<[CC1Option]>,<br> HelpText<"Enable migration to use NS_NONATOMIC_IOSONLY macro for setting property's 'atomic' attribute">;<br>+def objcmt_white_list_dir_path: Joined<["-"], "objcmt-white-list-dir-path=">, Flags<[CC1Option]>,<br>+ HelpText<"Only modify files with a filename contained in the provided directory path">;<br></blockquote><br>Hi Argyrios,<br><br>Whitelist is one word.<br><br>This set of changes will need s/white[_-]list/whitelist/ and s/WhiteList/Whitelist/.<br><br>If you need compatibility with the misspelt form it's OK to add an option alias.<br></div></blockquote><div><br></div><div>I changed it with r196944 and added an alias.</div><div>Please don't change the option from the test case. At some point I'll remove the alias and update the test.</div></div><br></body></html>