<div dir="ltr">Awesome. Thanks for fixing this Takumi!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 5, 2013 at 6:00 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br>
Date: Thu Dec  5 20:00:41 2013<br>
New Revision: 196559<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=196559&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=196559&view=rev</a><br>
Log:<br>
clang-tools-extra/test/clang-modernize/HeaderReplacements/main.cpp: Dequote safe chars rather than hairy quoting.<br>
<br>
Thanks to Lang, to let me noticed.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/common_expected.yaml<br>
    clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main.cpp<br>
    clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main_expected.yaml<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/common_expected.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/common_expected.yaml?rev=196559&r1=196558&r2=196559&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/common_expected.yaml?rev=196559&r1=196558&r2=196559&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/common_expected.yaml (original)<br>
+++ clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/common_expected.yaml Thu Dec  5 20:00:41 2013<br>
@@ -1,19 +1,19 @@<br>
 ---<br>
-MainSourceFile:  $(path)/common.cpp<br>
+MainSourceFile:  '$(path)/common.cpp'<br>
 Replacements:<br>
-  - FilePath:        $(path)/common.h<br>
+  - FilePath:        '$(path)/common.h'<br>
     Offset:          506<br>
     Length:          2<br>
     ReplacementText: elem<br>
-  - FilePath:        $(path)/common.h<br>
+  - FilePath:        '$(path)/common.h'<br>
     Offset:          432<br>
     Length:          61<br>
     ReplacementText: '(auto & elem : C)'<br>
-  - FilePath:        $(path)/common.cpp<br>
+  - FilePath:        '$(path)/common.cpp'<br>
     Offset:          289<br>
     Length:          2<br>
     ReplacementText: elem<br>
-  - FilePath:        $(path)/common.cpp<br>
+  - FilePath:        '$(path)/common.cpp'<br>
     Offset:          206<br>
     Length:          63<br>
     ReplacementText: '(auto & elem : C1)'<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main.cpp?rev=196559&r1=196558&r2=196559&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main.cpp?rev=196559&r1=196558&r2=196559&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main.cpp (original)<br>
+++ clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main.cpp Thu Dec  5 20:00:41 2013<br>
@@ -12,10 +12,10 @@<br>
 // RUN: ls -1 %T/SerializeTest | FileCheck %s --check-prefix=MAIN_CPP<br>
 // RUN: ls -1 %T/SerializeTest | FileCheck %s --check-prefix=COMMON_CPP<br>
 // We need to put the build path to the expected YAML file to diff against the generated one.<br>
-// RUN: sed -e 's#$(path)#%/T/SerializeTest#g' -e "s#\([A-Z]:/.*\.[chp]*\)#'\1'#g" %S/main_expected.yaml > %T/SerializeTest/main_expected.yaml<br>
+// RUN: sed -e 's#$(path)#%/T/SerializeTest#g' -e "s#[^[:space:]]'[^[:space:]]#''#g" -e "s#'\([-a-zA-Z0-9_/^., \t]*\)'#\1#g" %S/main_expected.yaml > %T/SerializeTest/main_expected.yaml<br>

 // RUN: sed -i -e 's#\\#/#g' %T/SerializeTest/main.cpp_*.yaml<br>
 // RUN: diff -b %T/SerializeTest/main_expected.yaml %T/SerializeTest/main.cpp_*.yaml<br>
-// RUN: sed -e 's#$(path)#%/T/SerializeTest#g' -e "s#\([A-Z]:/.*\.[chp]*\)#'\1'#g" %S/common_expected.yaml > %T/SerializeTest/common_expected.yaml<br>
+// RUN: sed -e 's#$(path)#%/T/SerializeTest#g' -e "s#[^[:space:]]'[^[:space:]]#''#g" -e "s#'\([-a-zA-Z0-9_/^., \t]*\)'#\1#g" %S/common_expected.yaml > %T/SerializeTest/common_expected.yaml<br>

 // RUN: sed -i -e 's#\\#/#g' %T/SerializeTest/common.cpp_*.yaml<br>
 // RUN: diff -b %T/SerializeTest/common_expected.yaml %T/SerializeTest/common.cpp_*.yaml<br>
 //<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main_expected.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main_expected.yaml?rev=196559&r1=196558&r2=196559&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main_expected.yaml?rev=196559&r1=196558&r2=196559&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main_expected.yaml (original)<br>
+++ clang-tools-extra/trunk/test/clang-modernize/HeaderReplacements/main_expected.yaml Thu Dec  5 20:00:41 2013<br>
@@ -1,11 +1,11 @@<br>
 ---<br>
-MainSourceFile:      $(path)/main.cpp<br>
+MainSourceFile:      '$(path)/main.cpp'<br>
 Replacements:<br>
-  - FilePath:        $(path)/common.h<br>
+  - FilePath:        '$(path)/common.h'<br>
     Offset:          506<br>
     Length:          2<br>
     ReplacementText: elem<br>
-  - FilePath:        $(path)/common.h<br>
+  - FilePath:        '$(path)/common.h'<br>
     Offset:          432<br>
     Length:          61<br>
     ReplacementText: '(auto & elem : C)'<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>