<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 02/12/2013 08:24, Daniel Jasper
wrote:<br>
</div>
<blockquote
cite="mid:CAK_tg0w+Z_3g77_p8JF=kyReR7vBH6Yrbd4frxR5aZZdC9HkTw@mail.gmail.com"
type="cite">
<div dir="ltr">I just tried reproducing this and it still works
fine here (both in vim and in emacs). Are you sure that
clang-format removes that trailing whitespace?</div>
</blockquote>
<br>
Hi Daniel,<br>
<br>
I think Rafael is onto something.<br>
<br>
If you take a look at r196038 in clang-tools-extra, there's an
unrelated whitespace fix that slipped into the commit yesterday:<br>
<br>
<br>
<code>@@ -262,7 +262,7 @@ StatementMatcher
makePseudoArrayLoopMatcher() {</code><code><br>
</code><code> // Test that the incoming type has a record
declaration that has methods</code><code><br>
</code><code> // called 'begin' and 'end'. If the incoming type is
const, then make sure</code><code><br>
</code><code> // these methods are also marked const.</code><code><br>
</code><code>- // </code><code><br>
</code><code>+ //</code><code><br>
</code><code> // FIXME: To be completely thorough this matcher
should also ensure the</code><code><br>
</code><code> // return type of begin/end is an iterator that
dereferences to the same as</code><code><br>
</code><code> // what operator[] or at() returns. Such a test
isn't likely to fail except</code><br>
<br>
The line that was legitimately changed is a fair bit above so I
wouldn't have expected to see this edit to an untouched line.<br>
<br>
I can try re-creating the patch as it was before running
clang-format if it'd be any help.<br>
<br>
diff -U0 | clang-format-diff.py -p1 -i<br>
<br>
Alp.<br>
<br>
<br>
<blockquote
cite="mid:CAK_tg0w+Z_3g77_p8JF=kyReR7vBH6Yrbd4frxR5aZZdC9HkTw@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
On Sun, Dec 1, 2013 at 7:01 PM, Rafael Espíndola <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
This seems to have caused a regression with at least the
emacs<br>
integration. Running clang-format-region now seems to remove
trailing<br>
white space from unrelated areas. For example, run it with
the cursor<br>
in Sema.cpp:1112:<br>
<br>
if (!LangOpts.RetainCommentsFromSystemHeaders &&<br>
<br>
and the trailing white space in Sema.cpp:1100:<br>
<br>
// We have a generic lambda if we parsed auto parameters, or
we have<br>
<br>
is removed.<br>
<br>
Cheers,<br>
Rafael<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.nuanti.com">http://www.nuanti.com</a>
the browser experts
</pre>
</body>
</html>