<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 24/11/2013 14:40, Aaron Ballman
wrote:<br>
</div>
<blockquote
cite="mid:CAAt6xTsy+xNALby0n9wtm8Xh5Oic+wjwYwF7xK8bcexsnUupyQ@mail.gmail.com"
type="cite">
<pre wrap="">What happens with this patch and the following ill-formed declaration:
struct S {} __declspec(deprecated);
Does this compile without error? If so, that would need to be
diagnosed (and regardless, this would be a good test to have). Note,
that code compiled with MSVC does not issue a diagnostic, but it also
doesn't apply the declspec to anything. I would say this should issue
a warning for us, and not apply the declspec to anything for greatest
compatibility vs utility.</pre>
</blockquote>
<br>
My patch handles that correctly. Here's the test:<br>
<code></code><code><br>
</code><code>test/SemaCXX/MicrosoftExtensions.cpp:416:26: warning:
attribute 'deprecated' is ignored, place it after "struct" to
apply attribute to type declaration<br>
struct D {} __declspec(deprecated);<br>
</code><br>
Alp.<br>
<br>
<blockquote
cite="mid:CAAt6xTsy+xNALby0n9wtm8Xh5Oic+wjwYwF7xK8bcexsnUupyQ@mail.gmail.com"
type="cite">
<pre wrap="">
~Aaron
On Sun, Nov 24, 2013 at 8:08 AM, Alp Toker <a class="moz-txt-link-rfc2396E" href="mailto:alp@nuanti.com"><alp@nuanti.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi David,
The attached patch fixes __declspec parsing after the class specification.
Verified against MSVC.
Alp.
--
<a class="moz-txt-link-freetext" href="http://www.nuanti.com">http://www.nuanti.com</a>
the browser experts
_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.nuanti.com">http://www.nuanti.com</a>
the browser experts
</pre>
</body>
</html>