<div dir="ltr">Hi,<div><br></div><div>any progress on this?</div><div><br>Cheers,<br>Daniel</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 9, 2013 at 6:40 PM, <span dir="ltr"><<a href="mailto:roman@himmes.com" target="_blank">roman@himmes.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
Quoting <a href="mailto:roman@himmes.com" target="_blank">roman@himmes.com</a>:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
template <><br>
<br>
+struct ScalarEnumerationTraits<clang:<u></u>:format::FormatStyle::<u></u>PointerBindingKind> {<br>
<br>
+ static void enumeration(IO &IO,<br>
<br>
+ clang::format::FormatStyle::<u></u>PointerBindingKind &Value) {<br>
<br>
+ IO.enumCase(Value, "Left", clang::format::FormatStyle::<u></u>PB_Left);<br>
<br>
+ IO.enumCase(Value, "Middle", clang::format::FormatStyle::<u></u>PB_Middle);<br>
<br>
+ IO.enumCase(Value, "Right", clang::format::FormatStyle::<u></u>PB_Right);<br>
<br>
<br>
</blockquote>
While this alignment might seem nice, I don't think it adds a lot of value.<br>
I'd rather keep this file clang-format clean.<br>
</blockquote>
<br>
At first I thought that this alignment is quite exotic, but entering "const std::sting & str" into goole I found that there are a few libraries out there using this alignment.<br>
Poco for example. So I see only 2 choices to support this style:<br>
Either have a config option like in this patch, or removing that explicit option and have that Middle style only auto detected.<br>
</blockquote>
<br></div>
Sorry I did not get your point. I just realized that there are some spaces too much and you were referring to them.<br>
<br>
Best Regards,<br>
<br>
Roman Himmes<br>
<br>
<br>
<br>
<br>
</blockquote></div><br></div>