<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Nov 21, 2013 at 11:49 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alp<br>
Date: Fri Nov 22 01:49:39 2013<br>
New Revision: 195419<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=195419&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=195419&view=rev</a><br>
Log:<br>
Make ASTUnit structure stable with NDEBUG<br></blockquote><div><br></div><div>I don't believe this is a goal. Is it?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
ASTUnit instances are allocated infrequently so it's fine to keep this field<br>
around in all build configurations.<br>
<br>
Assigns null to silence -Wunused-private-field in Release.<br></blockquote><div><br></div><div>That seems like a strange way to silence the warning, can you use an unused or used attribute instead, perhaps?</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/include/clang/Frontend/ASTUnit.h<br>
    cfe/trunk/lib/Frontend/ASTUnit.cpp<br>
<br>
Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/ASTUnit.h?rev=195419&r1=195418&r2=195419&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Frontend/ASTUnit.h?rev=195419&r1=195418&r2=195419&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/Frontend/ASTUnit.h (original)<br>
+++ cfe/trunk/include/clang/Frontend/ASTUnit.h Fri Nov 22 01:49:39 2013<br>
@@ -406,9 +406,7 @@ private:<br>
   /// just about any usage.<br>
   /// Becomes a noop in release mode; only useful for debug mode checking.<br>
   class ConcurrencyState {<br>
-#ifndef NDEBUG<br>
     void *Mutex; // a llvm::sys::MutexImpl in debug;<br>
-#endif<br>
<br>
   public:<br>
     ConcurrencyState();<br>
<br>
Modified: cfe/trunk/lib/Frontend/ASTUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/ASTUnit.cpp?rev=195419&r1=195418&r2=195419&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/ASTUnit.cpp?rev=195419&r1=195418&r2=195419&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Frontend/ASTUnit.cpp (original)<br>
+++ cfe/trunk/lib/Frontend/ASTUnit.cpp Fri Nov 22 01:49:39 2013<br>
@@ -2953,7 +2953,7 @@ void ASTUnit::ConcurrencyState::finish()<br>
<br>
 #else // NDEBUG<br>
<br>
-ASTUnit::ConcurrencyState::ConcurrencyState() {}<br>
+ASTUnit::ConcurrencyState::ConcurrencyState() { Mutex = 0; }<br>
 ASTUnit::ConcurrencyState::~ConcurrencyState() {}<br>
 void ASTUnit::ConcurrencyState::start() {}<br>
 void ASTUnit::ConcurrencyState::finish() {}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>