<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Nov 21, 2013 at 8:19 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="im">On Thu, Nov 21, 2013 at 8:12 PM, Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes. A style option makes perfect sense. I am just (moderately) against implementing a filename-based detection in ClangFormat.cpp.</div>
</blockquote><div><br></div></div><div>I see. Yea, might not be super useful, true...</div></div></div></div></blockquote><div><br></div><div>It might be useful for default styles: one can just invoke clang-format -style=google test.js, and get a sane result. And I don't think it will ever make sense to format .js files in C++ mode. But I don't feel strongly either.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Nov 21, 2013 at 11:11 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Thu, Nov 21, 2013 at 8:05 PM, Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think JS and C++ will almost always be in different sub-directories. So different .clang-format files are the way to go..</div>
</blockquote><div><br></div></div><div>That would be an argument for putting it in as a style option, right?</div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Nov 21, 2013 at 10:45 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Thu, Nov 21, 2013 at 7:38 PM, Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
After thinking some more, I guess my main reason is that I strongly doubt<br>
that we'll ever have a JavaScript style and a C++ style that are identical<br>
in all aspects other than the LanguageStandard.. So, the detection based on<br>
the file extension inside clang-format will likely be redundant..<br></blockquote><div><br></div></div><div>I think this would be useful for mixed open source projects (or companies without an existing style guide).</div>
<div>
One interesting point is that our configuration is very "repo" centric, and there are enough mixed repos out there - how would we want to support this without major setup effort required for every engineer contributing to a project...</div>
</div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div></div><br></div></div>
</blockquote></div></div></div></div></blockquote></div></div></div></div></div></blockquote></div><br>
</div></div>