<div dir="ltr">Wouldn't the right fix have been to s/"/'/g?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Nov 17, 2013 at 5:49 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alp<br>
Date: Sun Nov 17 10:49:24 2013<br>
New Revision: 194969<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194969&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194969&view=rev</a><br>
Log:<br>
Remove a bad string compare from r194968<br>
<br>
  lib/Tooling/CompilationDatabase.cpp:275:34: warning: result of comparison against a string literal is unspecified (use strncmp instead) [-Wstring-compare]<br>
<br>
This assert() should probably be fixed and added back at some point.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Tooling/CompilationDatabase.cpp<br>
<br>
Modified: cfe/trunk/lib/Tooling/CompilationDatabase.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/CompilationDatabase.cpp?rev=194969&r1=194968&r2=194969&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/CompilationDatabase.cpp?rev=194969&r1=194968&r2=194969&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Tooling/CompilationDatabase.cpp (original)<br>
+++ cfe/trunk/lib/Tooling/CompilationDatabase.cpp Sun Nov 17 10:49:24 2013<br>
@@ -272,7 +272,6 @@ bool stripPositionalArgs(std::vector<con<br>
   End = std::remove_if(Args.begin(), End, MatchesAny(DiagClient.UnusedInputs));<br>
<br>
   // Remove the -c add above as well. It will be at the end right now.<br>
-  assert(*(End - 1) == "-c");<br>
   --End;<br>
<br>
   Result = std::vector<std::string>(Args.begin() + 1, End);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>