<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Nov 15, 2013, at 3:40 PM, Yaron Keren <<a href="mailto:yaron.keren@gmail.com">yaron.keren@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="rtl"><div dir="ltr">It may be ok for the library (I did not check yet if ntdef.h or minwindef.h are not included indirectly somehow) but will pose a possible problem for the libcxx user: </div><div dir="ltr">if he includes libcxx header followed by <windows.h> without <span style="font-size:12.800000190734863px;font-family:arial,sans-serif">NOMINMAX</span> defined he would get min and max defined and trouble.<br>
</div><div dir="ltr"><br></div><div dir="ltr">So to be on the safe side, we would like to get <span style="font-size:12.800000190734863px;font-family:arial,sans-serif">NOMINMAX</span> always defined.</div><div dir="ltr">
<br>
</div><div dir="ltr">What do you think about moving the code to __config:</div><div dir="ltr"><br></div><div dir="ltr">#ifdef _WIN32</div><div dir="ltr"><div dir="ltr">#ifndef NOMINMAX</div><div dir="ltr">#define NOMINMAX</div>
<div dir="ltr">#endif</div><div>#endif</div><div><br></div><div>It will work if the library user includes libcxx before window.h.</div><div><br></div><div>In the reverse case we can't avoid getting min and max defined but __undef_min_max will warn and undef them.</div></div></div></blockquote><div><br></div>In general, I think that this is a bad idea; we're dictating policy to the user of the library.</div><div><br></div><div>Besides, it already exists :-) in include/support/win32/support.h.</div><div><br></div><div><br></div><div>-- Marshall</div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px; "><br>Marshall Clow Idio Software <<a href="mailto:mclow.lists@gmail.com">mailto:mclow.lists@gmail.com</a>><br><br>A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).<br> -- Yu Suzuki</span>
</div>
<br></body></html>