<div dir="ltr">Hi Alexander,<div><br></div><div>Your commit broke the ARM buildbot.</div><div><br></div><div><a href="http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/13364/steps/check-all/logs/Clang%3A%3Adarwin-sanitizer-ld.c">http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/13364/steps/check-all/logs/Clang%3A%3Adarwin-sanitizer-ld.c</a><br>
</div><div><br></div><div>cheers,</div><div>--renato</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 15 November 2013 16:07, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: glider<br>
Date: Fri Nov 15 10:07:44 2013<br>
New Revision: 194820<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194820&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194820&view=rev</a><br>
Log:<br>
[ASan] Link with libclang_rt.asan_iossim_dynamic.dylib when targeting the iOS simulator.<br>
Add a test.<br>
<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/ToolChains.cpp<br>
    cfe/trunk/test/Driver/darwin-sanitizer-ld.c<br>
<br>
Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=194820&r1=194819&r2=194820&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=194820&r1=194819&r2=194820&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>
+++ cfe/trunk/lib/Driver/ToolChains.cpp Fri Nov 15 10:07:44 2013<br>
@@ -329,8 +329,17 @@ void DarwinClang::AddLinkRuntimeLibArgs(<br>
         // The ASAN runtime library requires C++.<br>
         AddCXXStdlibLibArgs(Args, CmdArgs);<br>
       }<br>
-      AddLinkRuntimeLib(Args, CmdArgs,<br>
-                        "libclang_rt.asan_osx_dynamic.dylib", true);<br>
+      if (isTargetMacOS()) {<br>
+        AddLinkRuntimeLib(Args, CmdArgs,<br>
+                          "libclang_rt.asan_osx_dynamic.dylib",<br>
+                          true);<br>
+      } else {<br>
+        if (isTargetIOSSimulator()) {<br>
+          AddLinkRuntimeLib(Args, CmdArgs,<br>
+                            "libclang_rt.asan_iossim_dynamic.dylib",<br>
+                            true);<br>
+        }<br>
+      }<br>
     }<br>
   }<br>
<br>
<br>
Modified: cfe/trunk/test/Driver/darwin-sanitizer-ld.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/darwin-sanitizer-ld.c?rev=194820&r1=194819&r2=194820&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/darwin-sanitizer-ld.c?rev=194820&r1=194819&r2=194820&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/Driver/darwin-sanitizer-ld.c (original)<br>
+++ cfe/trunk/test/Driver/darwin-sanitizer-ld.c Fri Nov 15 10:07:44 2013<br>
@@ -9,6 +9,14 @@<br>
 // CHECK-ASAN: libclang_rt.asan_osx_dynamic.dylib"<br>
<br>
 // RUN: %clang -no-canonical-prefixes -### -target x86_64-darwin \<br>
+// RUN:   -fsanitize=address -mios-simulator-version-min=7.0 %s -o %t.o 2>&1 \<br>
+// RUN:   | FileCheck --check-prefix=CHECK-ASAN-IOSSIM %s<br>
+<br>
+// CHECK-ASAN-IOSSIM: "{{.*}}ld{{(.exe)?}}"<br>
+// CHECK-ASAN-IOSSIM: stdc++<br>
+// CHECK-ASAN-IOSSIM: libclang_rt.asan_iossim_dynamic.dylib"<br>
+<br>
+// RUN: %clang -no-canonical-prefixes -### -target x86_64-darwin \<br>
 // RUN:   -fPIC -shared -fsanitize=address %s -o %t.so 2>&1 \<br>
 // RUN:   | FileCheck --check-prefix=CHECK-DYN-ASAN %s<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>