<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Thanks!<br>
<br>
<div>I understand that comment.<br>
<br>
It sounds good to test a more general property. However I don't see a good simple candidate property. User classes that has various types of constructors can often be memset without problems. There might for instance be dataloss when a memset is used but imho
it's difficult to see if this is intentional or not.<br>
<br>
I do believe we could write more generic warnings when the memset leads to undefined behaviour such as division by zero or null pointer dereference. However this is not very trivial to check, as far as I see. I am not against this I am just not volounteering
to write such check right now.<br>
<br>
<br>
<div style="font-family:Tahoma; font-size:13px">
<div style="font-family:Tahoma; font-size:13px">
<div style="font-family:Tahoma; font-size:13px">
<div style="font-family:Tahoma; font-size:13px">
<div style="font-family:Tahoma; font-size:13px">
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt">..................................................................................................................</span></p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:black; font-size:8pt">Daniel Marjamäki
</span><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt">Senior Engineer</span></p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8.5pt" lang="EN-US">Evidente ES East</span><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-US"> AB<span>
</span>Warfvinges väg 34<span> </span>SE-112 51 Stockholm<span> </span>Sweden </span>
</p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-US"></span> </p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-GB">Mobile</span><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-GB">:<span>
</span>+46 (0)709 12 42 62</span></p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-GB"></span><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-GB">E-mail:<span>
</span><span> <a href="mailto:Daniel.Marjamaki@evidente.se" tabindex="0">
Daniel.Marjamaki</a></span><a href="mailto:Daniel.Marjamaki@evidente.se" tabindex="0">@evidente.se</a><span>
</span><span> </span></span></p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; color:gray; font-size:8pt" lang="EN-GB"></span> </p>
<p class="MsoNormal" style="margin:0cm 0cm 0pt"><span style="font-family:'Arial','sans-serif'; font-size:8pt" lang="EN-GB">www.evidente.se</span></p>
</div>
</div>
</div>
</div>
</div>
</div>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF978788"><font color="#000000" face="Tahoma" size="2"><b>Från:</b> metafoo@gmail.com [metafoo@gmail.com] för Richard Smith [richard@metafoo.co.uk]<br>
<b>Skickat:</b> den 14 november 2013 00:34<br>
<b>Till:</b> Daniel Marjamäki<br>
<b>Cc:</b> cfe-commits@cs.uiuc.edu<br>
<b>Ämne:</b> Re: [PATCH] New warning when using memset etc on std class data<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">Testing for class members with types in namespace std seems extremely ad-hoc and rather hacky. Can we test for a more general and defensible property instead, like checking whether the class type has a trivial default constructor?</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Nov 13, 2013 at 3:27 PM, Daniel Marjamäki <span dir="ltr">
<<a href="mailto:Daniel.Marjamaki@evidente.se" target="_blank">Daniel.Marjamaki@evidente.se</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<br>
Hello!<br>
<br>
I'd like to get comments / reviews for this patch.<br>
<br>
clang currently writes warnings if memset is used on a class that contains virtual methods.<br>
<br>
This patch adds warnings when memset is used on a class that contains std class members. This can cause weird bugs.<br>
<br>
I have seen such bugs in a closed source project. And there was also a major cleanup of such bugs a few years ago in boinc.<br>
<br>
Best regards,<br>
Daniel Marjamäki<br>
<br>
..................................................................................................................<br>
Daniel Marjamäki<br>
Senior Engineer<br>
Evidente ES East AB<br>
Warfvinges väg 34 SE-112 51 Stockholm Sweden<br>
<br>
<br>
Mobile:<br>
<a href="tel:%2B46%20%280%29709%2012%2042%2062" value="+46709124262" target="_blank">+46 (0)709 12 42 62</a><br>
E-mail:<br>
<br>
<a href="mailto:Daniel.Marjamaki@evidente.se" target="_blank">Daniel.Marjamaki@evidente.se</a><br>
<br>
<br>
<a href="http://www.evidente.se" target="_blank">www.evidente.se</a><br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>