<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 13, 2013, at 2:00 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra">You're missing the 'namespace experimental {' from the synopsis.</div><div class="gmail_extra"><br></div><div class="gmail_extra">The alias templates in the tests seem like overkill. Could you use 'using std::experimental::dynarray;' ?</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Otherwise, LGTM.<br></div></div></blockquote><div><br></div>Thanks. Committed with your suggestions as revision 194614.</div><div><br></div><div>-- Marshall</div><div><br><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 13, 2013 at 12:26 PM, Marshall Clow <span dir="ltr"><<a href="mailto:mclow.lists@gmail.com" target="_blank">mclow.lists@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">[ META: This is the second (of two) patches that I want to land that move stuff that didn't make the C++14 standard into "experimental". ]<br>
<br>
<br>
Along with C++14, the standard committee is working on several "Technical Specifications", designed to bring features that for one reason or another weren't able to be in C++14 to people before the next version of the standard (C++17??). Those of you who remember TR1 (from about 2005) - this is a similar process under a new name.<br>
<br>
There are several being worked on:<br>
* Library Fundamentals<br>
* Arrays of Runtime Bound<br>
* Networking<br>
* Concepts<br>
* Filesystem<br>
<br>
This patch takes the implementation of <dynarray> that I wrote and committed into libc++ (before the committee removed the feature from C++14), and moves it into the new "experimental" area, which is where these TSes will live until they are enshrined in a future version of the standard.<br>
<br>
That area can be described as:<br>
namespace std::experimental (feel free to alias this to something shorter in your code)<br>
files live in the "experimental/" directory.<br>
<br>
If you're already using the <dynarray> in libc++, you'll have to change your code to:<br>
#include <experimental/dynarray><br>
and use<br>
std::experimental:: dynarray <T><br>
<br>
It's a good-sized patch, but it's just renaming things; if I actually changed some code, then I did it wrong.<br>
<br>
I believe that I have addressed all of Richard's concerns with the <optional> patch here.<br>
* Versioned inline namespace "inline namespace __array_extensions_v1"<br>
* Nothing in std::<br>
<br>
[ I will re-submit the optional patch soon. ]<br>
<br>
-- Marshall<br>
<br>
Marshall Clow Idio Software <mailto:<a href="mailto:mclow.lists@gmail.com">mclow.lists@gmail.com</a>><br>
<br>
A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).<br>
-- Yu Suzuki<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>
</blockquote></div><br>
<br></body></html>