<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thanks for the feedback. I have attached the improved patch.<br>
<br>
Thanks,<br>
Johan<br>
<br>
<br>
<div class="moz-cite-prefix">On 8-11-2013 22:25, Sean Silva wrote:<br>
</div>
<blockquote
cite="mid:CAHnXoamUZEugp98M7G1hJ+pA+L4kffLA5Tt0vf97+Bh+f0KCig@mail.gmail.com"
type="cite">
<div dir="ltr">Your patch doesn't do what you think. In Python 2,
it is still invoking a print statement with the expression
`(error)` which happens to evaluate to just `error`. You need a
`from __future__ import print_function`, which will make it be a
function call in both Python 2 and 3.
<div>
<div><br>
</div>
<div>-- Sean Silva</div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Nov 8, 2013 at 3:57 PM, Johan
Engelen <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jbc.engelen@swissonline.ch" target="_blank">jbc.engelen@swissonline.ch</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
Sublime Text 3 uses Python 3.3 for its plugins (instead of
2.6 that Sublime Text 2 uses). The attached patch fixes
clang-format-sublime.py to work in Sublime Text 3.<br>
I am not a Python expert, but it seems for this plugin, the
only relevant change is that "print" became a function, so
parens are needed.<br>
I tested the change and the patched plugin works in both
Sublime Text 2 and 3.<br>
<br>
Thanks for the review, (and commit ;)<span class="HOEnZb"><font
color="#888888"><br>
Johan<br>
</font></span><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>