<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">More tests are coming. I’m doing it incrementally, in groups of related callbacks.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> cfe-commits-bounces@cs.uiuc.edu [mailto:cfe-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>David Blaikie<br>
<b>Sent:</b> Tuesday, November 05, 2013 8:19 AM<br>
<b>To:</b> John Thompson<br>
<b>Cc:</b> llvm cfe<br>
<b>Subject:</b> Re: [clang-tools-extra] r194079 - [extra] pp-trace - Fixed problems found while writing docs.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Is there missing test coverage for these cases?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Tue, Nov 5, 2013 at 6:16 AM, John Thompson <<a href="mailto:John.Thompson.JTSoftware@gmail.com" target="_blank">John.Thompson.JTSoftware@gmail.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: jtsoftware<br>
Date: Tue Nov 5 08:16:11 2013<br>
New Revision: 194079<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194079&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=194079&view=rev</a><br>
Log:<br>
[extra] pp-trace - Fixed problems found while writing docs.<br>
<br>
Modified:<br>
clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp<br>
clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h<br>
<br>
Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp?rev=194079&r1=194078&r2=194079&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp?rev=194079&r1=194078&r2=194079&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp (original)<br>
+++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp Tue Nov 5 08:16:11 2013<br>
@@ -166,7 +166,7 @@ void PPCallbacksTracker::Ident(clang::So<br>
const std::string &Str) {<br>
beginCallback("Ident");<br>
appendArgument("Loc", Loc);<br>
- appendArgument("Path", Str);<br>
+ appendQuotedArgument("Str", Str);<br>
}<br>
<br>
// Callback invoked when start reading any pragma directive.<br>
@@ -175,7 +175,7 @@ PPCallbacksTracker::PragmaDirective(clan<br>
clang::PragmaIntroducerKind Introducer) {<br>
beginCallback("PragmaDirective");<br>
appendArgument("Loc", Loc);<br>
- appendArgument("Path", Introducer, PragmaIntroducerKindStrings);<br>
+ appendArgument("Introducer", Introducer, PragmaIntroducerKindStrings);<br>
}<br>
<br>
// Callback invoked when a #pragma comment directive is read.<br>
<br>
Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h?rev=194079&r1=194078&r2=194079&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h?rev=194079&r1=194078&r2=194079&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h (original)<br>
+++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h Tue Nov 5 08:16:11 2013<br>
@@ -160,9 +160,6 @@ public:<br>
/// \brief Append a string to the top trace item.<br>
void append(const char *Str);<br>
<br>
- /// \brief Format and append a string to the top trace item.<br>
- void appendFormatted(const char *Format, ...);<br>
-<br>
/// \brief Append a bool argument to the top trace item.<br>
void appendArgument(const char *Name, bool Value);<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>